Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 306443002: Revert "Merge v8globals.h and globals.h" (Closed)

Created:
6 years, 7 months ago by Toon Verwaest
Modified:
6 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Revert "Merge v8globals.h and globals.h" Because of tree redness. TBR=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21483

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -881 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/accessors.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/circular-queue.h View 1 chunk +1 line, -1 line 0 comments Download
M src/counters.h View 1 chunk +1 line, -1 line 0 comments Download
M src/globals.h View 2 chunks +0 lines, -541 lines 0 comments Download
M src/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/platform.h View 1 chunk +1 line, -1 line 0 comments Download
M src/sampler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/small-pointer-list.h View 1 chunk +1 line, -1 line 0 comments Download
M src/store-buffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/v8.h View 1 chunk +1 line, -1 line 0 comments Download
A + src/v8globals.h View 2 chunks +6 lines, -328 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Toon Verwaest
6 years, 7 months ago (2014-05-26 08:39:20 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r21483 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698