Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 306413002: Rename Repaint to Paint Invalidation Part 2 (Closed)

Created:
6 years, 6 months ago by dsinclair
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, jchaffraix+rendering, pdr., rune+blink
Visibility:
Public.

Description

Rename Repaint to Paint Invalidation Part 2 This CL refactors the FrameView methods to be paintInvalidation instead of repaint. I have left the repaint rect output to be 'repaint' for now as that seems like a large and scary rebaseline when it lands. I also did not change the slowRepaints methods as they were previously mentioned as not having to do with paint invalidation. BUG=338691 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175492

Patch Set 1 #

Patch Set 2 : Rebase to master #

Total comments: 6

Patch Set 3 : #

Patch Set 4 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -76 lines) Patch
M Source/core/frame/FrameView.h View 1 2 3 7 chunks +11 lines, -11 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 2 3 21 chunks +53 lines, -53 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderView.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderView.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/scroll/ScrollView.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/scroll/ScrollView.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
dsinclair
PTAL.
6 years, 6 months ago (2014-06-02 19:17:14 UTC) #1
Julien - ping for review
lgtm but the description is too wide (it should be <80 characters sir!) https://codereview.chromium.org/306413002/diff/20001/Source/core/frame/FrameView.cpp File ...
6 years, 6 months ago (2014-06-03 01:00:20 UTC) #2
dsinclair
https://codereview.chromium.org/306413002/diff/20001/Source/core/frame/FrameView.cpp File Source/core/frame/FrameView.cpp (right): https://codereview.chromium.org/306413002/diff/20001/Source/core/frame/FrameView.cpp#newcode359 Source/core/frame/FrameView.cpp:359: IntRect paintInavlidationRect = rect; On 2014/06/03 01:00:20, Julien Chaffraix ...
6 years, 6 months ago (2014-06-03 14:06:17 UTC) #3
dsinclair
ping ojan, esprehn for Source/web/OWNERS.
6 years, 6 months ago (2014-06-04 13:30:06 UTC) #4
eseidel
rslgtm
6 years, 6 months ago (2014-06-04 14:50:53 UTC) #5
dsinclair
The CQ bit was checked by dsinclair@chromium.org
6 years, 6 months ago (2014-06-04 14:58:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/306413002/50001
6 years, 6 months ago (2014-06-04 14:59:39 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 15:20:03 UTC) #8
Message was sent while issue was closed.
Change committed as 175492

Powered by Google App Engine
This is Rietveld 408576698