Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3064041: Landing r5180 and r5178 from bleeding_edge.... (Closed)

Created:
10 years, 4 months ago by Vyacheslav Egorov (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Landing r5180 and r5178 from bleeding_edge to 2.2 branch. Fix handling of DEBUG_BREAK_SLOT and JS_RETURN relocations across platforms: - on ia32 add DEBUG_BREAK_SLOT to RelocInfo::kApplyMask - on x64 remove JS_RETURN from RelocInfo::kApply mask and incorrect code for JS_RETURN and DEBUG_BREAK_SLOT from RelocInfo::apply. Committed: http://code.google.com/p/v8/source/detail?r=5185

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -53 lines) Patch
M src/arm/assembler-arm-inl.h View 2 chunks +8 lines, -10 lines 0 comments Download
M src/assembler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/assembler-ia32-inl.h View 1 chunk +10 lines, -9 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 2 chunks +6 lines, -13 lines 0 comments Download
M test/cctest/test-debug.cc View 3 chunks +52 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
10 years, 4 months ago (2010-08-05 13:59:00 UTC) #1
Søren Thygesen Gjesse
10 years, 4 months ago (2010-08-05 14:16:36 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698