Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 306373002: Add SkBarriers_tsan.h. (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add SkBarriers_tsan.h. Slight counterproposal to crrev.com/310663002. BUG=skia: No API changes. TBR= Committed: https://skia.googlesource.com/skia/+/a8928b745a7158a432033a28c49fb0f0450ccf6e

Patch Set 1 #

Patch Set 2 : revert annotation when split into _tsan.h #

Patch Set 3 : undo #

Patch Set 4 : __has_feature #

Patch Set 5 : remove suppressions #

Patch Set 6 : tweak #

Total comments: 1

Patch Set 7 : return void #

Patch Set 8 : SK_HAS_COMPILER_FEATURE #

Patch Set 9 : rebase #

Patch Set 10 : elif #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -10 lines) Patch
M include/core/SkPostConfig.h View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -1 line 0 comments Download
A src/ports/SkBarriers_tsan.h View 1 2 3 4 5 6 1 chunk +48 lines, -0 lines 0 comments Download
M tools/tsan.supp View 1 2 3 4 5 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
mtklein
6 years, 6 months ago (2014-06-03 15:09:38 UTC) #1
bungeman-skia
lgtm https://codereview.chromium.org/306373002/diff/100001/src/ports/SkBarriers_tsan.h File src/ports/SkBarriers_tsan.h (right): https://codereview.chromium.org/306373002/diff/100001/src/ports/SkBarriers_tsan.h#newcode42 src/ports/SkBarriers_tsan.h:42: T sk_acquire_load(T* ptr) { return SkBarriers<T, 8*sizeof(T)>::AcquireLoad(ptr); } ...
6 years, 6 months ago (2014-06-03 15:23:54 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-03 15:28:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/306373002/120001
6 years, 6 months ago (2014-06-03 15:29:08 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 15:29:11 UTC) #5
commit-bot: I haz the power
Presubmit check for 306373002-120001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 6 months ago (2014-06-03 15:29:11 UTC) #6
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-03 15:29:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/306373002/120001
6 years, 6 months ago (2014-06-03 15:30:01 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 15:30:04 UTC) #9
commit-bot: I haz the power
Presubmit check for 306373002-120001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 6 months ago (2014-06-03 15:30:04 UTC) #10
mtklein
+reed for include/. No API changes. I thought TBR=reed@google.com or TBR= would bypass the check? ...
6 years, 6 months ago (2014-06-03 15:31:24 UTC) #11
mtklein
On 2014/06/03 15:31:24, mtklein wrote: > +reed for include/. No API changes. > > I ...
6 years, 6 months ago (2014-06-03 22:29:17 UTC) #12
reed1
lgtm
6 years, 6 months ago (2014-06-05 21:38:07 UTC) #13
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-05 22:03:16 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/306373002/140001
6 years, 6 months ago (2014-06-05 22:04:08 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 22:04:11 UTC) #16
commit-bot: I haz the power
Failed to apply patch for include/core/SkPostConfig.h: While running git apply --index -p1; error: patch failed: ...
6 years, 6 months ago (2014-06-05 22:04:12 UTC) #17
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-05 22:07:58 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/306373002/160001
6 years, 6 months ago (2014-06-05 22:09:08 UTC) #19
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-05 22:17:25 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/306373002/180001
6 years, 6 months ago (2014-06-05 22:17:28 UTC) #21
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 13:21:59 UTC) #22
Message was sent while issue was closed.
Change committed as a8928b745a7158a432033a28c49fb0f0450ccf6e

Powered by Google App Engine
This is Rietveld 408576698