Update me2me connect-to-local-host browser-test to not perform keyboard validation.

This should enable us to get the simpler connect-to-local-host browser-test running first, then move on to adding keyboard input validation.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274669

[anandc, 2014-06-03 01:19:38]

Hi Weitao, PTAL. Thanks.

[anandc, 2014-06-03 17:32:18]

+jamiewalch@ as reviewer, because Weitao is out today. PTAL. Thanks.

[Jamie, 2014-06-03 17:44:04]

Rather than removing this code, how about making it Linux-only? It seems a shame
to lose this test coverage just because it needs a virtual desktop. Or is there
some other reason for removing it?

[anandc, 2014-06-03 17:49:11]

On 2014/06/03 17:44:04, Jamie wrote:
> Rather than removing this code, how about making it Linux-only? It seems a
shame
> to lose this test coverage just because it needs a virtual desktop. Or is
there
> some other reason for removing it?

I think this extra work is overloading the test case. We want to test if
connecting to host succeeded. If it did, test case passes; if not it fails.
Verifying if keyboard input and mouse input works should be a separate test.
So, yes, while we remove the keyboard input validation here, it is not going to
be lost, but will be a separate test.

[Jamie, 2014-06-03 17:50:28]

On 2014/06/03 17:49:11, anandc wrote:
> On 2014/06/03 17:44:04, Jamie wrote:
> > Rather than removing this code, how about making it Linux-only? It seems a
> shame
> > to lose this test coverage just because it needs a virtual desktop. Or is
> there
> > some other reason for removing it?
> 
> I think this extra work is overloading the test case. We want to test if
> connecting to host succeeded. If it did, test case passes; if not it fails.
> Verifying if keyboard input and mouse input works should be a separate test.
> So, yes, while we remove the keyboard input validation here, it is not going
to
> be lost, but will be a separate test.

Fair enough. LGTM.

[anandc, 2014-06-03 17:55:34]

On 2014/06/03 17:50:28, Jamie wrote:
> On 2014/06/03 17:49:11, anandc wrote:
> > On 2014/06/03 17:44:04, Jamie wrote:
> > > Rather than removing this code, how about making it Linux-only? It seems a
> > shame
> > > to lose this test coverage just because it needs a virtual desktop. Or is
> > there
> > > some other reason for removing it?
> > 
> > I think this extra work is overloading the test case. We want to test if
> > connecting to host succeeded. If it did, test case passes; if not it fails.
> > Verifying if keyboard input and mouse input works should be a separate test.
> > So, yes, while we remove the keyboard input validation here, it is not going
> to
> > be lost, but will be a separate test.
> 
> Fair enough. LGTM.

Created a bug to track the separate keyboard input test:
ttps://code.google.com/p/chromium/issues/detail?id=380257

[anandc, 2014-06-03 17:55:38]

The CQ bit was checked by anandc@chromium.org

[weitao, 2014-06-03 17:56:06]

On 2014/06/03 17:50:28, Jamie wrote:
> On 2014/06/03 17:49:11, anandc wrote:
> > On 2014/06/03 17:44:04, Jamie wrote:
> > > Rather than removing this code, how about making it Linux-only? It seems a
> > shame
> > > to lose this test coverage just because it needs a virtual desktop. Or is
> > there
> > > some other reason for removing it?
> > 
> > I think this extra work is overloading the test case. We want to test if
> > connecting to host succeeded. If it did, test case passes; if not it fails.
> > Verifying if keyboard input and mouse input works should be a separate test.
> > So, yes, while we remove the keyboard input validation here, it is not going
> to
> > be lost, but will be a separate test.
> 
> Fair enough. LGTM.

We already spoke yesterday. LGTM to me as well. And no, I am not out today,
despite what I have said.

[commit-bot: I haz the power, 2014-06-03 17:56:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/anandc@chromium.org/306343006/1

[commit-bot: I haz the power, 2014-06-03 23:44:27]

Change committed as 274669