chrome/browser/profiles/profile_manager_browsertest.cc - Issue 306343002: Disable ProfileManagerBrowserTest.DeletePasswords on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_manager_browsertest.cc

Issue 306343002: Disable ProfileManagerBrowserTest.DeletePasswords on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/profiles/profile_manager_browsertest.cc

diff --git a/chrome/browser/profiles/profile_manager_browsertest.cc b/chrome/browser/profiles/profile_manager_browsertest.cc

index 42e83480ad5a6c3a0abaad13fccaccac2d06323e..1ed99f794a8be2b666dd1d4169f8371e69e7a2a8 100644

--- a/chrome/browser/profiles/profile_manager_browsertest.cc

+++ b/chrome/browser/profiles/profile_manager_browsertest.cc

@@ -396,6 +396,9 @@ IN_PROC_BROWSER_TEST_F(ProfileManagerBrowserTest, EphemeralProfile) {

ASSERT_EQ(1U, cache.GetNumberOfProfiles());

}

+// The test is ending with timeout on Win. It's not important because there is

+// no keychain on Windows.

battre 2014/06/02 13:18:03 nit: Keychain (capital letter)

+#if !defined(OS_WIN)

IN_PROC_BROWSER_TEST_F(ProfileManagerBrowserTest, DeletePasswords) {

Profile* profile = ProfileManager::GetActiveUserProfile();

ASSERT_TRUE(profile);

@@ -441,3 +444,4 @@ IN_PROC_BROWSER_TEST_F(ProfileManagerBrowserTest, DeletePasswords) {

EXPECT_TRUE(verify_delete.IsCalled());

EXPECT_EQ(0u, verify_delete.GetPasswords().size());

}

+#endif

battre 2014/06/02 13:18:03 #endif // !defined(OS_WIN) ?

« no previous file with comments | « no previous file | no next file » | no next file with comments »