Chromium Code Reviews
Help | Chromium Project | Sign in
(25)

Issue 3063031: Mac: more tabpose (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by Nico
Modified:
4 years ago
CC:
chromium-reviews, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Mac: more tabpose Add layout logic, add layers, add entry/exit animations, add mouse selection of layers. Most things are functional, but no thumbnail images are shown yet. Why is the Tile stuff c++ classes instead of objc classes? Because some of the linux folks said they'd like to see this on linux too, so I don't want to make it too hard for me to port this to other platforms if this survives the experiment stage. Why is the Tile stuff not in its own file then? Because things are still far from settled down, and this way it's easier for me to change things around. BUG=50307 TEST= * All the following happens only if --enable-expose-for-tabs is passed in, else all of it should be disabled. * Activate tabpose. One layer per tab should appear, they should be layed out in a sensible manner * Layout should also be sensible if the window has extreme width to height ratios. * Layers can be selected by hovering them with the mouse. enter, space, and clicking all select the currently selected layer. esc animated back to the initially selected layer * If shift is down when tabpose is entered or left, the animation plays in slow motion * For now, the layers are just black rects with a shadow or a white rect with a shadow for the selected layer. * Shadows are not shown while the entry or exit animations are running (because animating shadows is very slow, and it's not noticable that they're not there during the animation) * When a layer has been selected, the corresponding tab is selected once the exit animation is done * The selected layer should animate to the size of the tab contents (minus download shelf, if visible): It should include infobars, the detached bookmarks bar on the ntp, and devtools. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55482

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : shadows! #

Patch Set 8 : '' #

Patch Set 9 : test? #

Total comments: 13

Patch Set 10 : '' #

Patch Set 11 : reviewable #

Patch Set 12 : '' #

Total comments: 19

Patch Set 13 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+531 lines, -22 lines) Patch
M chrome/browser/cocoa/browser_window_controller.mm View 1 2 3 4 5 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/cocoa/tabpose_window.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +39 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/tabpose_window.mm View 1 2 3 4 5 6 7 8 9 10 11 12 6 chunks +464 lines, -10 lines 0 comments Download
M chrome/browser/cocoa/tabpose_window_unittest.mm View 1 2 3 4 5 6 7 8 2 chunks +24 lines, -9 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 6 (0 generated)
viettrungluu
I just took a quick look at the first little bit. Could you add a ...
4 years, 9 months ago (2010-08-08 23:25:34 UTC) #1
Nico
Thanks! Didn't upload a new snapshot yet, but here are my replies. http://codereview.chromium.org/3063031/diff/18001/19002 File chrome/browser/cocoa/tabpose_window.h ...
4 years, 9 months ago (2010-08-08 23:41:53 UTC) #2
Nico
New snapshot up. This is now ready for review.
4 years, 9 months ago (2010-08-09 01:33:08 UTC) #3
Robert Sesek
http://codereview.chromium.org/3063031/diff/27001/28002 File chrome/browser/cocoa/tabpose_window.h (right): http://codereview.chromium.org/3063031/diff/27001/28002#newcode16 chrome/browser/cocoa/tabpose_window.h:16: class Tile; nit: Insert blank line before this. http://codereview.chromium.org/3063031/diff/27001/28002#newcode54 ...
4 years, 9 months ago (2010-08-09 20:00:11 UTC) #4
Nico
thanks! http://codereview.chromium.org/3063031/diff/27001/28002 File chrome/browser/cocoa/tabpose_window.h (right): http://codereview.chromium.org/3063031/diff/27001/28002#newcode16 chrome/browser/cocoa/tabpose_window.h:16: class Tile; On 2010/08/09 20:00:11, rsesek wrote: > ...
4 years, 9 months ago (2010-08-09 20:31:24 UTC) #5
Robert Sesek
4 years, 9 months ago (2010-08-09 21:46:11 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be