Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: components/bookmarks/browser/bookmark_model.h

Issue 306293006: Introduce ChromeBookmarkClientFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@364865
Patch Set: Add missing dependency in components/policy/policy_browser.gypi Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/bookmarks/browser/bookmark_client.h ('k') | components/policy/policy_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/bookmarks/browser/bookmark_model.h
diff --git a/components/bookmarks/browser/bookmark_model.h b/components/bookmarks/browser/bookmark_model.h
index 9e2a8be68c1037bbf32be76c76c0c8ffc8d9f418..5c750029f024651d32c1fe071fede6a45b0f5485 100644
--- a/components/bookmarks/browser/bookmark_model.h
+++ b/components/bookmarks/browser/bookmark_model.h
@@ -19,6 +19,7 @@
#include "base/synchronization/waitable_event.h"
#include "components/bookmarks/browser/bookmark_client.h"
#include "components/bookmarks/browser/bookmark_node.h"
+#include "components/keyed_service/core/keyed_service.h"
#include "ui/gfx/image/image.h"
#include "url/gurl.h"
@@ -58,7 +59,7 @@ class TestBookmarkClient;
//
// You should NOT directly create a BookmarkModel, instead go through the
// BookmarkModelFactory.
-class BookmarkModel {
+class BookmarkModel : public KeyedService {
public:
struct URLAndTitle {
GURL url;
@@ -68,10 +69,10 @@ class BookmarkModel {
// |index_urls| says whether URLs should be stored in the BookmarkIndex
// in addition to bookmark titles.
BookmarkModel(BookmarkClient* client, bool index_urls);
- ~BookmarkModel();
+ virtual ~BookmarkModel();
- // Invoked prior to destruction to release any necessary resources.
- void Shutdown();
+ // KeyedService:
+ virtual void Shutdown() OVERRIDE;
// Loads the bookmarks. This is called upon creation of the
// BookmarkModel. You need not invoke this directly.
« no previous file with comments | « components/bookmarks/browser/bookmark_client.h ('k') | components/policy/policy_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698