chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc - Issue 306293006: Introduce ChromeBookmarkClientFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc

Issue 306293006: Introduce ChromeBookmarkClientFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@364865

Patch Set: Add missing dependency in components/policy/policy_browser.gypi Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc ('k') | chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc

diff --git a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc

index 31c57d1d507f980b9fdeea255574afe6a340e9d3..c7c0fc7d394ddabdb551918f4e5a4ce4f933cbf2 100644

--- a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc

+++ b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc

@@ -10,6 +10,7 @@

#include "base/values.h"

#include "chrome/browser/bookmarks/bookmark_model_factory.h"

#include "chrome/browser/bookmarks/chrome_bookmark_client.h"

+#include "chrome/browser/bookmarks/chrome_bookmark_client_factory.h"

#include "chrome/browser/extensions/extension_apitest.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

@@ -28,9 +29,9 @@

IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_BookmarkManager) {

// Add managed bookmarks.

Profile* profile = browser()->profile();

+ BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile);

ChromeBookmarkClient* client =

- BookmarkModelFactory::GetChromeBookmarkClientForProfile(profile);

- BookmarkModel* model = client->model();

+ ChromeBookmarkClientFactory::GetForProfile(profile);

test::WaitForBookmarkModelToLoad(model);

base::ListValue list;