Issue 306293005: Convert SVGSMILElement::resolveInterval to return an SMILInterval

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 306293005: Convert SVGSMILElement::resolveInterval to return an SMILInterval (Closed)

Created:
6 years, 6 months ago by fs

Modified:
6 years, 6 months ago

Reviewers:
pdr.

CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Convert SVGSMILElement::resolveInterval to return an SMILInterval Rather than using two out-/reference parameters to return the result, use the return value. Also convert the 'bool first' argument to the method to an enumeration. With the above SVGSMILElement::resolve{First,Next}Interval can be simplified a bit. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175321

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -22 lines)			Patch
	M	Source/core/svg/animation/SVGSMILElement.h	View		1 chunk	+7 lines, -1 line	0 comments	Download
	M	Source/core/svg/animation/SVGSMILElement.cpp	View		4 chunks	+13 lines, -21 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/306293005/1

6 years, 6 months ago (2014-06-02 19:51:09 UTC) #4

Message was sent while issue was closed.

Change committed as 175321

Expand Messages | Collapse Messages