Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 306293002: Update FlakyTests to match current flakiness dashboard results (Closed)

Created:
6 years, 6 months ago by eseidel
Modified:
6 years, 6 months ago
Reviewers:
eseidel, ojan
CC:
blink-reviews, Dirk Pranke, eseidel, pfeldman, Julien - ping for review, eae
Visibility:
Public.

Description

Update FlakyTests to match current flakiness dashboard results Automatically generated using: webkit-patch update-flaky-tests R=eseidel BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175238

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -255 lines) Patch
M LayoutTests/FlakyTests View 10 chunks +265 lines, -255 lines 2 comments Download

Messages

Total messages: 10 (0 generated)
eseidel
6 years, 6 months ago (2014-06-01 23:31:42 UTC) #1
ojan
lgtm FWIW, I think it'd be fine to TBR these.
6 years, 6 months ago (2014-06-01 23:32:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/306293002/1
6 years, 6 months ago (2014-06-01 23:33:10 UTC) #3
eseidel
It looks like inspector tests are surprisingly flaky on linux. Definitely some systematic trouble on ...
6 years, 6 months ago (2014-06-01 23:33:27 UTC) #4
eseidel
Currently I'm running upload with --reviewers=eseidel, but normally it would just upload for the gardeners ...
6 years, 6 months ago (2014-06-01 23:34:23 UTC) #5
eseidel
https://codereview.chromium.org/306293002/diff/1/LayoutTests/FlakyTests File LayoutTests/FlakyTests (right): https://codereview.chromium.org/306293002/diff/1/LayoutTests/FlakyTests#newcode159 LayoutTests/FlakyTests:159: Bug(gardener) [ Release Win7 ] fast/table/table-cell-before-after-content-around-table-block.html [ Failure Pass ...
6 years, 6 months ago (2014-06-01 23:35:33 UTC) #6
ojan
Also, nit: please change the script to not put in the empty BUG= line.
6 years, 6 months ago (2014-06-01 23:53:31 UTC) #7
ojan
On 2014/06/01 23:34:23, eseidel wrote: > Currently I'm running upload with --reviewers=eseidel, but normally it ...
6 years, 6 months ago (2014-06-01 23:54:02 UTC) #8
ojan
eae! https://codereview.chromium.org/306293002/diff/1/LayoutTests/FlakyTests File LayoutTests/FlakyTests (right): https://codereview.chromium.org/306293002/diff/1/LayoutTests/FlakyTests#newcode159 LayoutTests/FlakyTests:159: Bug(gardener) [ Release Win7 ] fast/table/table-cell-before-after-content-around-table-block.html [ Failure ...
6 years, 6 months ago (2014-06-01 23:58:57 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 00:47:47 UTC) #10
Message was sent while issue was closed.
Change committed as 175238

Powered by Google App Engine
This is Rietveld 408576698