Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 306273002: Oilpan: fix WebSocket unit tests memory leaks. (Closed)

Created:
6 years, 6 months ago by sof
Modified:
6 years, 6 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Oilpan: fix WebSocket unit tests memory leaks. Remove unnecessary Persistent reference (to an object contained within another Persistent) + arrange for manual GCing of resources to avoid test objects being reported as not destructed and leaking with Oilpan enabled. R= BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175233

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -79 lines) Patch
M Source/modules/websockets/WebSocketTest.cpp View 31 chunks +83 lines, -79 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
sof
Please take a look. Addresses the webkit_unit_tests seen with Oilpan enabled (cf. https://codereview.chromium.org/298893008/ ) Note: ...
6 years, 6 months ago (2014-06-01 21:28:52 UTC) #1
sof
Just in case this isn't known.. one added reason for caring about webkit_unit_tests failures is ...
6 years, 6 months ago (2014-06-01 21:34:10 UTC) #2
tkent
lgtm
6 years, 6 months ago (2014-06-01 23:03:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/306273002/1
6 years, 6 months ago (2014-06-01 23:03:12 UTC) #4
haraken
LGTM, thanks!
6 years, 6 months ago (2014-06-01 23:16:50 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-01 23:48:21 UTC) #6
commit-bot: I haz the power
Change committed as 175233
6 years, 6 months ago (2014-06-02 00:22:54 UTC) #7
tyoshino (SeeGerritForStatus)
lgtm
6 years, 6 months ago (2014-06-02 03:59:25 UTC) #8
yhirano
lgtm, thanks for doing this!
6 years, 6 months ago (2014-06-02 04:38:33 UTC) #9
sof
6 years, 6 months ago (2014-06-02 05:01:51 UTC) #10
Message was sent while issue was closed.
On 2014/06/02 04:38:33, yhirano wrote:
> lgtm, thanks for doing this!

Excellent, thanks for the quick reviews and handing it over to CQ right away.

Powered by Google App Engine
This is Rietveld 408576698