Split most extensions bits in ChromeRenderMessageFilter into ChromeExtensionMessageFilter.

Split most extensions bits in ChromeRenderMessageFilter into ChromeExtensionMessageFilter.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275430

[James Cook, 2014-06-03 16:07:15]

LGTM with nits

https://codereview.chromium.org/306233002/diff/20001/chrome/browser/chrome_co...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/306233002/diff/20001/chrome/browser/chrome_co...
chrome/browser/chrome_content_browser_client.cc:229: #if
defined(ENABLE_CAPTIVE_PORTAL_DETECTION)
Thanks for cleaning these up!

https://codereview.chromium.org/306233002/diff/20001/chrome/browser/renderer_...
File chrome/browser/renderer_host/chrome_extension_message_filter.cc (right):

https://codereview.chromium.org/306233002/diff/20001/chrome/browser/renderer_...
chrome/browser/renderer_host/chrome_extension_message_filter.cc:17: #include
"chrome/browser/profiles/profile_manager.h"
nit: Also #include "chrome/browser/profiles/profile.h" since this file uses
profile->IsOffTheRecord().

https://codereview.chromium.org/306233002/diff/20001/chrome/browser/renderer_...
File chrome/browser/renderer_host/chrome_extension_message_filter.h (right):

https://codereview.chromium.org/306233002/diff/20001/chrome/browser/renderer_...
chrome/browser/renderer_host/chrome_extension_message_filter.h:26: // This class
filters out incoming Chrome-specific IPC messages for the
nit: for -> from

https://codereview.chromium.org/306233002/diff/20001/chrome/browser/renderer_...
File chrome/browser/renderer_host/chrome_render_message_filter.cc (left):

https://codereview.chromium.org/306233002/diff/20001/chrome/browser/renderer_...
chrome/browser/renderer_host/chrome_render_message_filter.cc:98:
off_the_record_(profile_->IsOffTheRecord()),
Nice dead code removal.

https://codereview.chromium.org/306233002/diff/20001/chrome/browser/renderer_...
File chrome/browser/renderer_host/chrome_render_message_filter.cc (right):

https://codereview.chromium.org/306233002/diff/20001/chrome/browser/renderer_...
chrome/browser/renderer_host/chrome_render_message_filter.cc:279: void
ChromeRenderMessageFilter::OnCanTriggerClipboardRead(
Optional: These seem to only apply to extensions. What do you think about moving
them as well?  It would make this file even less ifdef-y.

[Lei Zhang, 2014-06-03 19:46:30]

https://codereview.chromium.org/306233002/diff/20001/chrome/browser/renderer_...
File chrome/browser/renderer_host/chrome_extension_message_filter.cc (right):

https://codereview.chromium.org/306233002/diff/20001/chrome/browser/renderer_...
chrome/browser/renderer_host/chrome_extension_message_filter.cc:17: #include
"chrome/browser/profiles/profile_manager.h"
On 2014/06/03 16:07:15, James Cook wrote:
> nit: Also #include "chrome/browser/profiles/profile.h" since this file uses
> profile->IsOffTheRecord().

Done.

https://codereview.chromium.org/306233002/diff/20001/chrome/browser/renderer_...
File chrome/browser/renderer_host/chrome_extension_message_filter.h (right):

https://codereview.chromium.org/306233002/diff/20001/chrome/browser/renderer_...
chrome/browser/renderer_host/chrome_extension_message_filter.h:26: // This class
filters out incoming Chrome-specific IPC messages for the
On 2014/06/03 16:07:15, James Cook wrote:
> nit: for -> from

Done.

https://codereview.chromium.org/306233002/diff/20001/chrome/browser/renderer_...
File chrome/browser/renderer_host/chrome_render_message_filter.cc (right):

https://codereview.chromium.org/306233002/diff/20001/chrome/browser/renderer_...
chrome/browser/renderer_host/chrome_render_message_filter.cc:279: void
ChromeRenderMessageFilter::OnCanTriggerClipboardRead(
On 2014/06/03 16:07:15, James Cook wrote:
> Optional: These seem to only apply to extensions. What do you think about
moving
> them as well?  It would make this file even less ifdef-y.

Might as well, done.

[Lei Zhang, 2014-06-03 19:46:32]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-06-03 19:47:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/306233002/40001

[commit-bot: I haz the power, 2014-06-04 00:42:19]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/12492)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/15576)

[commit-bot: I haz the power, 2014-06-04 01:07:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-04 01:07:37]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/12594)

[Lei Zhang, 2014-06-06 08:03:04]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-06-06 08:05:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/306233002/80001

[commit-bot: I haz the power, 2014-06-06 12:19:15]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-06-06 13:39:23]

Change committed as 275430