Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: src/api.cc

Issue 306203002: Remove PROHIBITS_OVERWRITING as it is subsumed by non-configurable properties. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Restore include/v8.h declaration to avoid dependencies Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/accessors.cc ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "api.h" 5 #include "api.h"
6 6
7 #include <string.h> // For memcpy, strlen. 7 #include <string.h> // For memcpy, strlen.
8 #ifdef V8_USE_ADDRESS_SANITIZER 8 #ifdef V8_USE_ADDRESS_SANITIZER
9 #include <sanitizer/asan_interface.h> 9 #include <sanitizer/asan_interface.h>
10 #endif // V8_USE_ADDRESS_SANITIZER 10 #endif // V8_USE_ADDRESS_SANITIZER
(...skipping 1126 matching lines...) Expand 10 before | Expand all | Expand 10 after
1137 1137
1138 static i::Handle<i::AccessorInfo> SetAccessorInfoProperties( 1138 static i::Handle<i::AccessorInfo> SetAccessorInfoProperties(
1139 i::Handle<i::AccessorInfo> obj, 1139 i::Handle<i::AccessorInfo> obj,
1140 v8::Handle<String> name, 1140 v8::Handle<String> name,
1141 v8::AccessControl settings, 1141 v8::AccessControl settings,
1142 v8::PropertyAttribute attributes, 1142 v8::PropertyAttribute attributes,
1143 v8::Handle<AccessorSignature> signature) { 1143 v8::Handle<AccessorSignature> signature) {
1144 obj->set_name(*Utils::OpenHandle(*name)); 1144 obj->set_name(*Utils::OpenHandle(*name));
1145 if (settings & ALL_CAN_READ) obj->set_all_can_read(true); 1145 if (settings & ALL_CAN_READ) obj->set_all_can_read(true);
1146 if (settings & ALL_CAN_WRITE) obj->set_all_can_write(true); 1146 if (settings & ALL_CAN_WRITE) obj->set_all_can_write(true);
1147 if (settings & PROHIBITS_OVERWRITING) obj->set_prohibits_overwriting(true);
1148 obj->set_property_attributes(static_cast<PropertyAttributes>(attributes)); 1147 obj->set_property_attributes(static_cast<PropertyAttributes>(attributes));
1149 if (!signature.IsEmpty()) { 1148 if (!signature.IsEmpty()) {
1150 obj->set_expected_receiver_type(*Utils::OpenHandle(*signature)); 1149 obj->set_expected_receiver_type(*Utils::OpenHandle(*signature));
1151 } 1150 }
1152 return obj; 1151 return obj;
1153 } 1152 }
1154 1153
1155 1154
1156 template<typename Getter, typename Setter> 1155 template<typename Getter, typename Setter>
1157 static i::Handle<i::AccessorInfo> MakeAccessorInfo( 1156 static i::Handle<i::AccessorInfo> MakeAccessorInfo(
(...skipping 6408 matching lines...) Expand 10 before | Expand all | Expand 10 after
7566 Isolate* isolate = reinterpret_cast<Isolate*>(info.GetIsolate()); 7565 Isolate* isolate = reinterpret_cast<Isolate*>(info.GetIsolate());
7567 Address callback_address = 7566 Address callback_address =
7568 reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback)); 7567 reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback));
7569 VMState<EXTERNAL> state(isolate); 7568 VMState<EXTERNAL> state(isolate);
7570 ExternalCallbackScope call_scope(isolate, callback_address); 7569 ExternalCallbackScope call_scope(isolate, callback_address);
7571 callback(info); 7570 callback(info);
7572 } 7571 }
7573 7572
7574 7573
7575 } } // namespace v8::internal 7574 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/accessors.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698