Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Side by Side Diff: src/accessors.cc

Issue 306203002: Remove PROHIBITS_OVERWRITING as it is subsumed by non-configurable properties. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Restore include/v8.h declaration to avoid dependencies Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « include/v8.h ('k') | src/api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "v8.h" 5 #include "v8.h"
6 #include "accessors.h" 6 #include "accessors.h"
7 7
8 #include "compiler.h" 8 #include "compiler.h"
9 #include "contexts.h" 9 #include "contexts.h"
10 #include "deoptimizer.h" 10 #include "deoptimizer.h"
(...skipping 23 matching lines...) Expand all
34 Isolate* isolate, 34 Isolate* isolate,
35 Handle<String> name, 35 Handle<String> name,
36 AccessorGetterCallback getter, 36 AccessorGetterCallback getter,
37 AccessorSetterCallback setter, 37 AccessorSetterCallback setter,
38 PropertyAttributes attributes) { 38 PropertyAttributes attributes) {
39 Factory* factory = isolate->factory(); 39 Factory* factory = isolate->factory();
40 Handle<ExecutableAccessorInfo> info = factory->NewExecutableAccessorInfo(); 40 Handle<ExecutableAccessorInfo> info = factory->NewExecutableAccessorInfo();
41 info->set_property_attributes(attributes); 41 info->set_property_attributes(attributes);
42 info->set_all_can_read(false); 42 info->set_all_can_read(false);
43 info->set_all_can_write(false); 43 info->set_all_can_write(false);
44 info->set_prohibits_overwriting(false);
45 info->set_name(*name); 44 info->set_name(*name);
46 Handle<Object> get = v8::FromCData(isolate, getter); 45 Handle<Object> get = v8::FromCData(isolate, getter);
47 Handle<Object> set = v8::FromCData(isolate, setter); 46 Handle<Object> set = v8::FromCData(isolate, setter);
48 info->set_getter(*get); 47 info->set_getter(*get);
49 info->set_setter(*set); 48 info->set_setter(*set);
50 return info; 49 return info;
51 } 50 }
52 51
53 52
54 Handle<ExecutableAccessorInfo> Accessors::CloneAccessor( 53 Handle<ExecutableAccessorInfo> Accessors::CloneAccessor(
(...skipping 1298 matching lines...) Expand 10 before | Expand all | Expand 10 after
1353 info->set_data(Smi::FromInt(index)); 1352 info->set_data(Smi::FromInt(index));
1354 Handle<Object> getter = v8::FromCData(isolate, &ModuleGetExport); 1353 Handle<Object> getter = v8::FromCData(isolate, &ModuleGetExport);
1355 Handle<Object> setter = v8::FromCData(isolate, &ModuleSetExport); 1354 Handle<Object> setter = v8::FromCData(isolate, &ModuleSetExport);
1356 info->set_getter(*getter); 1355 info->set_getter(*getter);
1357 if (!(attributes & ReadOnly)) info->set_setter(*setter); 1356 if (!(attributes & ReadOnly)) info->set_setter(*setter);
1358 return info; 1357 return info;
1359 } 1358 }
1360 1359
1361 1360
1362 } } // namespace v8::internal 1361 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « include/v8.h ('k') | src/api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698