Issue 306183002: Fixing clusterfuzz issue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 306183002: Fixing clusterfuzz issue (Closed)

Created:
6 years, 6 months ago by sugoi1

Modified:
6 years, 6 months ago

Reviewers:
mtklein, Stephen White, reed1

CC:
skia-review_googlegroups.com, qiankun

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Fixing clusterfuzz issue When reading an SkSSE2ProcCoeffXfermode object, fProcSIMD should never be NULL. The reason for this is that it's not possible to create such an object through SkPlatformXfermodeFactory_impl_SSE2(), which is the only function used to create these objects, so if we're reading one, it's clearly invalid. BUG=379181 Committed: http://code.google.com/p/skia/source/detail?r=15000

Patch Set 1 #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/opts/SkXfermode_opts_SSE2.cpp	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/sugoi@chromium.org/306183002/1

6 years, 6 months ago (2014-05-30 17:26:26 UTC) #5

Stephen White

6 years, 6 months ago (2014-06-02 13:13:34 UTC) #7

Message was sent while issue was closed.

https://codereview.chromium.org/306183002/diff/1/src/opts/SkXfermode_opts_SSE...
File src/opts/SkXfermode_opts_SSE2.cpp (right):

https://codereview.chromium.org/306183002/diff/1/src/opts/SkXfermode_opts_SSE...
src/opts/SkXfermode_opts_SSE2.cpp:647: buffer.validate(fProcSIMD != NULL);
Not new to this patch, but I wonder why we have such processor-specific
subclasses at all. Shouldn't the SKP format be processor-indepdendent? I.e.,
shouldn't we serialize generic implementations, and have the processing code
initialize callbacks for the platform it's running on?

Expand Messages | Collapse Messages