Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 306133002: WebServiceWorkerProxy instances can be unwrapped to ServiceWorkers. (Closed)

Created:
6 years, 6 months ago by dominicc (has gone to gerrit)
Modified:
6 years, 6 months ago
Reviewers:
tkent
CC:
blink-reviews, jsbell+serviceworker_chromium.org, jamesr, tzik, serviceworker-reviews, nhiroki, abarth-chromium, falken, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org, alecflett+watch_chromium.org
Visibility:
Public.

Description

WebServiceWorkerProxy instances can be unwrapped to ServiceWorkers. This does not change behavior because Chrome's service worker dispatcher always mints new WebServiceWorker instances, and WebServiceWorker::proxy returns null. BUG=361907 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175219

Patch Set 1 #

Patch Set 2 : Add exports to API used by modules. #

Patch Set 3 : Crib from WebNode: make m_private protected to avoid unused field warnings. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -5 lines) Patch
M Source/modules/serviceworkers/ServiceWorker.h View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorker.cpp View 2 chunks +16 lines, -1 line 0 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A Source/platform/exported/WebServiceWorkerProxy.cpp View 1 chunk +22 lines, -0 lines 0 comments Download
M public/platform/WebServiceWorker.h View 1 chunk +1 line, -0 lines 0 comments Download
M public/platform/WebServiceWorkerProxy.h View 1 2 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dominicc (has gone to gerrit)
PTAL This is a bit crazy but the problem is constrained: WebServiceWorkerProxy can't be a ...
6 years, 6 months ago (2014-05-30 05:03:43 UTC) #1
tkent
lgtm
6 years, 6 months ago (2014-05-30 06:13:39 UTC) #2
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 6 months ago (2014-05-30 06:27:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/306133002/1
6 years, 6 months ago (2014-05-30 06:28:48 UTC) #4
dominicc (has gone to gerrit)
The CQ bit was unchecked by dominicc@chromium.org
6 years, 6 months ago (2014-05-30 07:59:50 UTC) #5
dominicc (has gone to gerrit)
Cribbing from WebArrayBuffer, perhaps even the INSIDE_BLINK stuff needs exports?
6 years, 6 months ago (2014-05-30 08:56:18 UTC) #6
dominicc (has gone to gerrit)
I'm going to assume that the tweaked exports and member visibility are OK and CQ ...
6 years, 6 months ago (2014-06-01 08:28:46 UTC) #7
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 6 months ago (2014-06-01 08:28:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/306133002/40001
6 years, 6 months ago (2014-06-01 08:28:58 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-01 08:59:23 UTC) #10
Message was sent while issue was closed.
Change committed as 175219

Powered by Google App Engine
This is Rietveld 408576698