Do not double-unref send rights when using POLICY_SUBSTITUE_PORT.

sandbox/mac/launchd_interception_server.h

Index: sandbox/mac/launchd_interception_server.h
diff --git a/sandbox/mac/launchd_interception_server.h b/sandbox/mac/launchd_interception_server.h
index 6b92e9fa47ab04ecc570a01522478ed263e44e1f..bf061aea44f91d8f25a099e00e507db844ff04bc 100644
--- a/sandbox/mac/launchd_interception_server.h
+++ b/sandbox/mac/launchd_interception_server.h
@@ -54,8 +54,8 @@ class LaunchdInterceptionServer {
                          mach_msg_header_t* reply,
                          pid_t sender_pid);
 
-  // Sends a reply message.
-  void SendReply(mach_msg_header_t* reply);
+  // Sends a reply message. Returns true if the message was sent successfully.
+  bool SendReply(mach_msg_header_t* reply);
 
   // Forwards the original |request| on to real bootstrap server for handling.
   void ForwardMessage(mach_msg_header_t* request, mach_msg_header_t* reply);
@@ -88,6 +88,9 @@ class LaunchdInterceptionServer {
   // The Mach port handed out in reply to denied look up requests. All denied
   // requests share the same port, though nothing reads messages from it.
   base::mac::ScopedMachReceiveRight sandbox_port_;
+  // Any sandbox Rules that use the sandbox_port_ will need a send right to
+  // copy.

[Mark Mentovai, 2014/06/02 22:44:15]

This sentence is awkward. “will need a send right to be copied” is maybe a tiny
better. As it is, it kinda sounds like you need a send right to some receiver
named copy.

[Robert Sesek, 2014/06/02 23:28:51]

Done. Reworded to:

"The send right for the above |sandbox_port_|, used with MACH_MSG_TYPE_COPY_SEND
when handing out references to the dummy port."

+  base::mac::ScopedMachSendRight sandbox_send_port_;
 
   // The compatibility shim that handles differences in message header IDs and
   // request/reply structures between different OS X versions.