Do not double-unref send rights when using POLICY_SUBSTITUE_PORT.

Do not double-unref send rights when using POLICY_SUBSTITUE_PORT.

By destroying the reply message, the already-copied-out right will be unrefed
again, leading to an over-release of send rights.

This also requires that Rule(POLICY_SUBSTITUTE_PORT) users provide a send right
that can be duplicated with MACH_MSG_TYPE_COPY_SEND, rather than using MAKE_SEND.

BUG=367863
R=mark@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274467

[Mark Mentovai, 2014-06-02 22:44:15]

LGTM

https://codereview.chromium.org/306123012/diff/1/sandbox/mac/launchd_intercep...
File sandbox/mac/launchd_interception_server.h (right):

https://codereview.chromium.org/306123012/diff/1/sandbox/mac/launchd_intercep...
sandbox/mac/launchd_interception_server.h:92: // copy.
This sentence is awkward. “will need a send right to be copied” is maybe a tiny
better. As it is, it kinda sounds like you need a send right to some receiver
named copy.

[Robert Sesek, 2014-06-02 23:28:50]

https://codereview.chromium.org/306123012/diff/1/sandbox/mac/launchd_intercep...
File sandbox/mac/launchd_interception_server.h (right):

https://codereview.chromium.org/306123012/diff/1/sandbox/mac/launchd_intercep...
sandbox/mac/launchd_interception_server.h:92: // copy.
On 2014/06/02 22:44:15, Mark Mentovai wrote:
> This sentence is awkward. “will need a send right to be copied” is maybe a
tiny
> better. As it is, it kinda sounds like you need a send right to some receiver
> named copy.

Done. Reworded to:

"The send right for the above |sandbox_port_|, used with MACH_MSG_TYPE_COPY_SEND
when handing out references to the dummy port."

[Robert Sesek, 2014-06-02 23:28:55]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2014-06-02 23:30:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rsesek@chromium.org/306123012/20001

[commit-bot: I haz the power, 2014-06-03 10:48:28]

Change committed as 274467