Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2243)

Unified Diff: Source/devtools/front_end/timeline/TimelineModel.js

Issue 306123009: Remove TimelinePresentationModel.Record.childHasWarning (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineFlameChart.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/timeline/TimelineModel.js
diff --git a/Source/devtools/front_end/timeline/TimelineModel.js b/Source/devtools/front_end/timeline/TimelineModel.js
index 340dd826e54d3cdf172f5c96f7ff08440ea56100..01d023154bcc023be1ad383ce77e4437a433c0e3 100644
--- a/Source/devtools/front_end/timeline/TimelineModel.js
+++ b/Source/devtools/front_end/timeline/TimelineModel.js
@@ -663,11 +663,6 @@ WebInspector.TimelineModel.Record.prototype = {
warnings: function() { },
/**
- * @return {boolean}
- */
- childHasWarnings: function() { },
-
- /**
* @param {!RegExp} regExp
* @return {boolean}
*/
@@ -930,13 +925,9 @@ WebInspector.TimelineModel.RecordImpl.prototype = {
*/
addWarning: function(message)
{
- if (this._warnings)
- this._warnings.push(message);
- else {
- this._warnings = [message];
- for (var parent = this.parent; parent && !parent._childHasWarnings; parent = parent.parent)
- parent._childHasWarnings = true;
- }
+ if (!this._warnings)
+ this._warnings = [];
+ this._warnings.push(message);
},
/**
@@ -948,14 +939,6 @@ WebInspector.TimelineModel.RecordImpl.prototype = {
},
/**
- * @return {boolean}
- */
- childHasWarnings: function()
- {
- return !!this._childHasWarnings;
- },
-
- /**
* @param {!RegExp} regExp
* @return {boolean}
*/
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineFlameChart.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698