[DevTools] Fix responsive design UI issues.

Source/devtools/front_end/ResponsiveDesignView.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @extends {WebInspector.VBox}
  * @implements {WebInspector.OverridesSupport.PageResizer}
  * @param {!WebInspector.InspectedPagePlaceholder} inspectedPagePlaceholder
  */
@@ skipping 40 matching lines @@
     WebInspector.overridesSupport.settings.emulateViewport.addChangeListener(this._maybeEnableResponsiveDesign, this);
     WebInspector.overridesSupport.settings.emulateTouchEvents.addChangeListener(this._maybeEnableResponsiveDesign, this);
     WebInspector.overridesSupport.settings.overrideDeviceResolution.addChangeListener(this._maybeEnableResponsiveDesign, this);
 
     this._updateOverridesSupportOnDockSideChange();
 };
 
 // Measured in DIP.
 WebInspector.ResponsiveDesignView.SliderWidth = 19;
 WebInspector.ResponsiveDesignView.RulerWidth = 20;
-WebInspector.ResponsiveDesignView.ToolbarHeight = 24;
+WebInspector.ResponsiveDesignView.ToolbarHeight = 23;
 
 WebInspector.ResponsiveDesignView.prototype = {
     _maybeEnableResponsiveDesign: function()
     {
         if (this._enabled)
             return;
         if (WebInspector.overridesSupport.settings.emulateViewport.get() ||
                 WebInspector.overridesSupport.settings.emulateTouchEvents.get() ||
                 WebInspector.overridesSupport.settings.overrideDeviceResolution.get()) {
             WebInspector.settings.responsiveDesignMode.set(true);
         }
     },
 
     _responsiveDesignModeChanged: function()
     {
-        if (WebInspector.dockController.dockSide() === WebInspector.DockController.State.Undocked) {
-            WebInspector.overridesSupport.setPageResizer(null);
-            return;
-        }
-
         delete this._cachedScale;
         delete this._cachedCssCanvasWidth;
         delete this._cachedCssCanvasHeight;
         delete this._cachedCssHeight;
         delete this._cachedCssWidth;
         delete this._cachedZoomFactor;
         delete this._availableSize;
 
-        var enabled = WebInspector.settings.responsiveDesignMode.get();
+        var enabled = WebInspector.settings.responsiveDesignMode.get() && WebInspector.dockController.dockSide() !== WebInspector.DockController.State.Undocked;
         if (enabled && !this._enabled) {
             this._ignoreResize = true;
             this._enabled = true;
             this._inspectedPagePlaceholder.clearMinimumSizeAndMargins();
             this._inspectedPagePlaceholder.show(this._pageContainer);
             this._responsiveDesignContainer.show(this.element);
             WebInspector.overridesSupport.setPageResizer(this);
             delete this._ignoreResize;
         }
 
         if (!enabled && this._enabled) {

[apavlov, 2014/05/30 15:42:14]

"else if" ?

[dgozman, 2014/05/31 05:48:18]

I'll do this in next CL.

             this._ignoreResize = true;
             this._enabled = false;
             this._scale = 0;
             this._inspectedPagePlaceholder.restoreMinimumSizeAndMargins();
             this._responsiveDesignContainer.detach();
             this._inspectedPagePlaceholder.show(this.element);
             WebInspector.overridesSupport.setPageResizer(null);
             delete this._ignoreResize;
         }
     },
@@ skipping 354 matching lines @@
         if (this._warningMessage.textContent === message)
             return;
         this._warningMessage.classList.toggle("hidden", !message);
         this._warningMessage.textContent = message;
         this._responsiveDesignModeChanged();
         this.onResize();
     },
 
     __proto__: WebInspector.VBox.prototype
 };