chrome/utility/importer/firefox_importer_unittest_messages_internal.h - Issue 306123004: NSSDecryptor::ReadAndParseSignons() - improved password form scheme detection,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/utility/importer/firefox_importer_unittest_messages_internal.h

Issue 306123004: NSSDecryptor::ReadAndParseSignons() - improved password form scheme detection, (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes according to comments. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/utility/importer/firefox_importer_unittest.cc ('K') | « chrome/utility/importer/firefox_importer_unittest.cc ('k') | chrome/utility/importer/firefox_importer_unittest_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/utility/importer/firefox_importer_unittest_messages_internal.h

diff --git a/chrome/utility/importer/firefox_importer_unittest_messages_internal.h b/chrome/utility/importer/firefox_importer_unittest_messages_internal.h

index 8882ffbf37fdf5497ebc7201b0933cdca32c5689..20820cb33adea5b417a8f14e5f4d3e99c8df266e 100644

--- a/chrome/utility/importer/firefox_importer_unittest_messages_internal.h

+++ b/chrome/utility/importer/firefox_importer_unittest_messages_internal.h

@@ -2,6 +2,7 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+#include "chrome/common/importer/profile_import_process_messages.h"

#include "ipc/ipc_message_macros.h"

#define IPC_MESSAGE_START FirefoxImporterUnittestMsgStart

@@ -24,5 +25,10 @@ IPC_MESSAGE_CONTROL1(Msg_Decrypt,

IPC_MESSAGE_CONTROL1(Msg_Decryptor_Response,

base::string16 /* unencrypted_str */)

+IPC_MESSAGE_CONTROL1(Msg_ParseSignons_Response,

+ std::vector<autofill::PasswordForm>)

Ilya Sherman 2014/06/11 00:19:38 nit: Please follow the existing pattern in this fi

Lukasz Jagielski 2014/06/11 16:10:16 Done.

+IPC_MESSAGE_CONTROL1(Msg_ParseSignons, base::FilePath)

Ilya Sherman 2014/06/11 00:19:38 nit: Please add brief documentation for the added

Lukasz Jagielski 2014/06/11 16:10:16 Done.

// Server->Child: Die.

IPC_MESSAGE_CONTROL0(Msg_Decryptor_Quit)