chrome/utility/importer/nss_decryptor.cc - Issue 306123004: NSSDecryptor::ReadAndParseSignons() - improved password form scheme detection,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/utility/importer/nss_decryptor.cc

Issue 306123004: NSSDecryptor::ReadAndParseSignons() - improved password form scheme detection, (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: unittest added Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/utility/importer/firefox_importer_unittest_utils.h ('K') | « chrome/utility/importer/firefox_importer_unittest_utils_mac.cc ('k') | components/autofill/content/common/autofill_param_traits_macros.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/utility/importer/nss_decryptor.cc

diff --git a/chrome/utility/importer/nss_decryptor.cc b/chrome/utility/importer/nss_decryptor.cc

index 6b22ae2166f4ade49c02368031952f2e90c803d0..1a4f134962d1a0d17a2bc70d8ae2f722df5bf20a 100644

--- a/chrome/utility/importer/nss_decryptor.cc

+++ b/chrome/utility/importer/nss_decryptor.cc

@@ -284,8 +284,12 @@ bool NSSDecryptor::ReadAndParseSignons(const base::FilePath& sqlite_file,

autofill::PasswordForm form;

form.origin = url.ReplaceComponents(rep);

form.signon_realm = form.origin.GetOrigin().spec();

- if (!realm.empty())

+ if (!realm.empty()) {

form.signon_realm += realm;

+ // TODO(ljagielski) this isn't perfect, find out how to

+ // identify scheme digest

+ form.scheme = autofill::PasswordForm::SCHEME_BASIC;

+ }

form.ssl_valid = form.origin.SchemeIsSecure();

// The user name, password and action.

form.username_element = s2.ColumnString16(3);