NSSDecryptor::ReadAndParseSignons() - improved password form scheme detection,

chrome/utility/importer/nss_decryptor.cc

Index: chrome/utility/importer/nss_decryptor.cc
diff --git a/chrome/utility/importer/nss_decryptor.cc b/chrome/utility/importer/nss_decryptor.cc
index 6b22ae2166f4ade49c02368031952f2e90c803d0..1a4f134962d1a0d17a2bc70d8ae2f722df5bf20a 100644
--- a/chrome/utility/importer/nss_decryptor.cc
+++ b/chrome/utility/importer/nss_decryptor.cc
@@ -284,8 +284,12 @@ bool NSSDecryptor::ReadAndParseSignons(const base::FilePath& sqlite_file,
     autofill::PasswordForm form;
     form.origin = url.ReplaceComponents(rep);
     form.signon_realm = form.origin.GetOrigin().spec();
-    if (!realm.empty())
+    if (!realm.empty()) {
       form.signon_realm += realm;
+      // TODO(ljagielski) this isn't perfect, find out how to

[Ilya Sherman, 2014/05/30 23:17:54]

nit: "TODO(ljagielski)" -> "TODO(ljagielski):"

+      // identify scheme digest

[Ilya Sherman, 2014/05/30 23:17:54]

This TODO is a bit vague on what the problem is.  Please provide slightly more
detail, so that someone coming across this code out of context would still be
able to understand what this TODO is all about.

+      form.scheme = autofill::PasswordForm::SCHEME_BASIC;
+    }
     form.ssl_valid = form.origin.SchemeIsSecure();
     // The user name, password and action.
     form.username_element = s2.ColumnString16(3);