components/autofill/content/common/autofill_param_traits_macros.h - Issue 306123004: NSSDecryptor::ReadAndParseSignons() - improved password form scheme detection,

Side by Side Diff: components/autofill/content/common/autofill_param_traits_macros.h

Issue 306123004: NSSDecryptor::ReadAndParseSignons() - improved password form scheme detection, (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minor fixups Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/utility/importer/nss_decryptor.cc ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Singly or multiply-included shared traits file depending on circumstances.	5 // Singly or multiply-included shared traits file depending on circumstances.

6 // This allows the use of Autofill IPC serialization macros in more than one IPC	6 // This allows the use of Autofill IPC serialization macros in more than one IPC

7 // message file.	7 // message file.

8 #ifndef COMPONENTS_AUTOFILL_CONTENT_COMMON_AUTOFILL_PARAM_TRAITS_MACROS_H_	8 #ifndef COMPONENTS_AUTOFILL_CONTENT_COMMON_AUTOFILL_PARAM_TRAITS_MACROS_H_

9 #define COMPONENTS_AUTOFILL_CONTENT_COMMON_AUTOFILL_PARAM_TRAITS_MACROS_H_	9 #define COMPONENTS_AUTOFILL_CONTENT_COMMON_AUTOFILL_PARAM_TRAITS_MACROS_H_

10	10

11 #include "components/autofill/core/common/password_form.h"	11 #include "components/autofill/core/common/password_form.h"

12 #include "ipc/ipc_message_macros.h"	12 #include "ipc/ipc_message_macros.h"

13	13

14 IPC_ENUM_TRAITS_MAX_VALUE(autofill::PasswordForm::Type,	14 IPC_ENUM_TRAITS_MAX_VALUE(autofill::PasswordForm::Type,

15 autofill::PasswordForm::TYPE_LAST)	15 autofill::PasswordForm::TYPE_LAST)

16	16

17 IPC_STRUCT_TRAITS_BEGIN(autofill::FormData)	17 IPC_STRUCT_TRAITS_BEGIN(autofill::FormData)

18 IPC_STRUCT_TRAITS_MEMBER(name)	18 IPC_STRUCT_TRAITS_MEMBER(name)

19 IPC_STRUCT_TRAITS_MEMBER(method)	19 IPC_STRUCT_TRAITS_MEMBER(method)

20 IPC_STRUCT_TRAITS_MEMBER(origin)	20 IPC_STRUCT_TRAITS_MEMBER(origin)

21 IPC_STRUCT_TRAITS_MEMBER(action)	21 IPC_STRUCT_TRAITS_MEMBER(action)

22 IPC_STRUCT_TRAITS_MEMBER(user_submitted)	22 IPC_STRUCT_TRAITS_MEMBER(user_submitted)

23 IPC_STRUCT_TRAITS_MEMBER(fields)	23 IPC_STRUCT_TRAITS_MEMBER(fields)

24 IPC_STRUCT_TRAITS_END()	24 IPC_STRUCT_TRAITS_END()

25	25

	26 IPC_ENUM_TRAITS(autofill::PasswordForm::Scheme)
	dcheng 2014/06/12 03:24:20 Please use IPC_ENUM_TRAITS_MAX_VALUE. Also, where Please use IPC_ENUM_TRAITS_MAX_VALUE. Also, where is this IPC message sent/consumed? With a quick search, the only IPC message I see referencing it is AutofillMsg_FormNotBlacklisted -- is that the message the importer is using? dcheng 2014/06/12 03:24:20 Please use IPC_ENUM_TRAITS_MAX_VALUE. Also, where Please use IPC_ENUM_TRAITS_MAX_VALUE. Also, where is this IPC message sent/consumed? With a quick search, the only IPC message I see referencing it is AutofillMsg_FormNotBlacklisted -- is that the message the importer is using? Lukasz Jagielski 2014/06/12 07:52:38 There's a bunch of IPC messages using autofill::Pa There's a bunch of IPC messages using autofill::PasswordForm in components/autofill/content/common/autofill_messages.h Importer is using ProfileImportProcessHostMsg_NotifyPasswordFormReady defined in chrome/common/importer/profile_import_process_messages.h On 2014/06/12 03:24:20, dcheng wrote: Show quoted text > Please use IPC_ENUM_TRAITS_MAX_VALUE. Also, where is this IPC message > sent/consumed? With a quick search, the only IPC message I see referencing it is > AutofillMsg_FormNotBlacklisted -- is that the message the importer is using?
	27

26 IPC_STRUCT_TRAITS_BEGIN(autofill::PasswordForm)	28 IPC_STRUCT_TRAITS_BEGIN(autofill::PasswordForm)

	29 IPC_STRUCT_TRAITS_MEMBER(scheme)

27 IPC_STRUCT_TRAITS_MEMBER(signon_realm)	30 IPC_STRUCT_TRAITS_MEMBER(signon_realm)

28 IPC_STRUCT_TRAITS_MEMBER(origin)	31 IPC_STRUCT_TRAITS_MEMBER(origin)

29 IPC_STRUCT_TRAITS_MEMBER(action)	32 IPC_STRUCT_TRAITS_MEMBER(action)

30 IPC_STRUCT_TRAITS_MEMBER(submit_element)	33 IPC_STRUCT_TRAITS_MEMBER(submit_element)

31 IPC_STRUCT_TRAITS_MEMBER(username_element)	34 IPC_STRUCT_TRAITS_MEMBER(username_element)

32 IPC_STRUCT_TRAITS_MEMBER(username_value)	35 IPC_STRUCT_TRAITS_MEMBER(username_value)

33 IPC_STRUCT_TRAITS_MEMBER(other_possible_usernames)	36 IPC_STRUCT_TRAITS_MEMBER(other_possible_usernames)

34 IPC_STRUCT_TRAITS_MEMBER(password_element)	37 IPC_STRUCT_TRAITS_MEMBER(password_element)

35 IPC_STRUCT_TRAITS_MEMBER(password_value)	38 IPC_STRUCT_TRAITS_MEMBER(password_value)

36 IPC_STRUCT_TRAITS_MEMBER(password_autocomplete_set)	39 IPC_STRUCT_TRAITS_MEMBER(password_autocomplete_set)

37 IPC_STRUCT_TRAITS_MEMBER(old_password_element)	40 IPC_STRUCT_TRAITS_MEMBER(old_password_element)

38 IPC_STRUCT_TRAITS_MEMBER(old_password_value)	41 IPC_STRUCT_TRAITS_MEMBER(old_password_value)

39 IPC_STRUCT_TRAITS_MEMBER(ssl_valid)	42 IPC_STRUCT_TRAITS_MEMBER(ssl_valid)

40 IPC_STRUCT_TRAITS_MEMBER(preferred)	43 IPC_STRUCT_TRAITS_MEMBER(preferred)

41 IPC_STRUCT_TRAITS_MEMBER(blacklisted_by_user)	44 IPC_STRUCT_TRAITS_MEMBER(blacklisted_by_user)

42 IPC_STRUCT_TRAITS_MEMBER(type)	45 IPC_STRUCT_TRAITS_MEMBER(type)

43 IPC_STRUCT_TRAITS_MEMBER(times_used)	46 IPC_STRUCT_TRAITS_MEMBER(times_used)

44 IPC_STRUCT_TRAITS_MEMBER(form_data)	47 IPC_STRUCT_TRAITS_MEMBER(form_data)

45 // Excluding \|use_additional_authentication\| as it is only set and read in the	48 // Excluding \|use_additional_authentication\| as it is only set and read in the

46 // browser process and the renderer need not know about it.	49 // browser process and the renderer need not know about it.

47 IPC_STRUCT_TRAITS_END()	50 IPC_STRUCT_TRAITS_END()

48	51

49 #endif // COMPONENTS_AUTOFILL_CONTENT_COMMON_AUTOFILL_PARAM_TRAITS_MACROS_H_	52 #endif // COMPONENTS_AUTOFILL_CONTENT_COMMON_AUTOFILL_PARAM_TRAITS_MACROS_H_

OLD	NEW