Source/web/WebMediaPlayerClientImpl.h - Issue 306123003: Eliminate MediaPlayer & MediaPlayerClient abstractions(seek, duration, poster APIs)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebMediaPlayerClientImpl.h

Issue 306123003: Eliminate MediaPlayer & MediaPlayerClient abstractions(seek, duration, poster APIs) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed review comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebMediaPlayerClientImpl.h

diff --git a/Source/web/WebMediaPlayerClientImpl.h b/Source/web/WebMediaPlayerClientImpl.h

index 51cda0db29b767defcf7817b3e769600a4fc0f65..6024d80e237b4bb47f38996f00533220059032b9 100644

--- a/Source/web/WebMediaPlayerClientImpl.h

+++ b/Source/web/WebMediaPlayerClientImpl.h

@@ -97,14 +97,9 @@ public:

virtual void play() OVERRIDE;

virtual void pause() OVERRIDE;

virtual bool supportsSave() const OVERRIDE;

- virtual double duration() const OVERRIDE;

- virtual double currentTime() const OVERRIDE;

- virtual void seek(double time) OVERRIDE;

- virtual bool seeking() const OVERRIDE;

virtual double rate() const OVERRIDE;

virtual void setRate(double) OVERRIDE;

virtual bool paused() const OVERRIDE;

- virtual void setPoster(const WebCore::KURL&) OVERRIDE;

virtual WebCore::MediaPlayer::NetworkState networkState() const OVERRIDE;

virtual WebCore::MediaPlayer::ReadyState readyState() const OVERRIDE;

virtual double maxTimeSeekable() const OVERRIDE;

« Source/core/html/HTMLMediaElement.cpp ('K') | « Source/platform/graphics/media/MediaPlayer.h ('k') | Source/web/WebMediaPlayerClientImpl.cpp » ('j') | no next file with comments »