Eliminate MediaPlayer & MediaPlayerClient abstractions(seek, duration, poster APIs)

Source/core/html/HTMLMediaElement.cpp

 /*
  * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 1823 matching lines @@
         if (m_lastSeekTime < now)
             addPlayedRange(m_lastSeekTime, now);
     }
     m_lastSeekTime = time;
     m_sentEndEvent = false;
 
     // 8 - Queue a task to fire a simple event named seeking at the element.
     scheduleEvent(EventTypeNames::seeking);
 
     // 9 - Set the current playback position to the given new playback position
-    m_player->seek(time);
+    if (webMediaPlayer())

[acolwell GONE FROM CHROMIUM, 2014/06/02 22:34:17]

You should not need this check. You shouldn't be able to get to this point w/o
having a webMediaPlayer(). The only way to get m_readyState > HAVE_NOTHING is
for webMediaPlayer() to actually exist and triggered a transition to something
else.

[Srirama, 2014/06/03 07:06:02]

Done.

+        webMediaPlayer()->seek(time);
 
     // 10-14 are handled, if necessary, when the engine signals a readystate change or otherwise
     // satisfies seek completion and signals a time change.
 }
 
 void HTMLMediaElement::finishSeek()
 {
     WTF_LOG(Media, "HTMLMediaElement::finishSeek");
 
     // 4.8.10.9 Seeking completion
@@ skipping 19 matching lines @@
     return webMediaPlayer() && webMediaPlayer()->hasAudio();
 }
 
 bool HTMLMediaElement::seeking() const
 {
     return m_seeking;
 }
 
 void HTMLMediaElement::refreshCachedTime() const
 {
-    m_cachedTime = m_player->currentTime();
+    m_cachedTime = webMediaPlayer() ? webMediaPlayer()->currentTime() : 0.0;

[acolwell GONE FROM CHROMIUM, 2014/06/02 22:34:17]

You shouldn't need this check. This method shouldn't be called if we don't have
a webMediaPlayer().

[Srirama, 2014/06/03 07:06:02]

It is null for preload:none case, when it is called from updatePlayState. So
should we have this check here, or should i add it in updatePlayState ?

     m_cachedTimeWallClockUpdateTime = WTF::currentTime();
 }
 
 void HTMLMediaElement::invalidateCachedTime()
 {
     WTF_LOG(Media, "HTMLMediaElement::invalidateCachedTime");
 
     // Don't try to cache movie time when playback first starts as the time reported by the engine
     // sometimes fluctuates for a short amount of time, so the cached time will be off if we take it
     // too early.
@@ skipping 13 matching lines @@
     if (!m_player)
         return 0;
 
     if (m_seeking) {
         WTF_LOG(Media, "HTMLMediaElement::currentTime - seeking, returning %f", m_lastSeekTime);
         return m_lastSeekTime;
     }
 
     if (m_cachedTime != MediaPlayer::invalidTime() && m_paused) {
 #if LOG_CACHED_TIME_WARNINGS
-        double delta = m_cachedTime - m_player->currentTime();
+        double playerCurrentTime = webMediaPlayer() ? webMediaPlayer()->currentTime() : 0.0;

[acolwell GONE FROM CHROMIUM, 2014/06/02 22:34:17]

This check should be moved to the top with the !m_player check since it will
eventually replace it.

[Srirama, 2014/06/03 07:06:02]

Done.

+        double delta = m_cachedTime - playerCurrentTime;
         if (delta > minCachedDeltaForWarning)
             WTF_LOG(Media, "HTMLMediaElement::currentTime - WARNING, cached time is %f seconds off of media time when paused", delta);
 #endif
         return m_cachedTime;
     }
 
     refreshCachedTime();
 
     return m_cachedTime;
 }
@@ skipping 18 matching lines @@
     // case because MediaSourceBase and SourceBuffer do not notify the element
     // directly upon duration changes caused by endOfStream, remove, or append
     // operations; rather the notification is triggered by the WebMediaPlayer
     // implementation observing that the underlying engine has updated duration
     // and notifying the element to consult its MediaSource for current
     // duration. See http://crbug.com/266644
 
     if (m_mediaSource)
         return m_mediaSource->duration();
 
-    return m_player->duration();
+    return webMediaPlayer() ? webMediaPlayer()->duration() : 0.0;

[acolwell GONE FROM CHROMIUM, 2014/06/02 22:34:17]

This check should not be needed. webMediaPlayer() must be valid for m_readyState
>= HAVE_METADATA.

[Srirama, 2014/06/03 07:06:02]

Done.

 }
 
 bool HTMLMediaElement::paused() const
 {
     return m_paused;
 }
 
 double HTMLMediaElement::defaultPlaybackRate() const
 {
     return m_defaultPlaybackRate;
@@ skipping 795 matching lines @@
 
 void HTMLMediaElement::mediaPlayerTimeChanged()
 {
     WTF_LOG(Media, "HTMLMediaElement::mediaPlayerTimeChanged");
 
     updateActiveTextTrackCues(currentTime());
 
     invalidateCachedTime();
 
     // 4.8.10.9 steps 12-14. Needed if no ReadyState change is associated with the seek.
-    if (m_seeking && m_readyState >= HAVE_CURRENT_DATA && !m_player->seeking())
+    if (m_seeking && m_readyState >= HAVE_CURRENT_DATA
+        && !(webMediaPlayer() && webMediaPlayer()->seeking()))

[acolwell GONE FROM CHROMIUM, 2014/06/02 22:34:17]

the pointer check should not be necessary since webMediaPlayer() must be valid
if m_readyState >= HAVE_CURRENT_DATA. Also this method is actually being called
from the webMediaPlayer() instance so it better be non-null at this point.

[Srirama, 2014/06/03 07:06:02]

Done.

         finishSeek();
 
     // Always call scheduleTimeupdateEvent when the media engine reports a time discontinuity,
     // it will only queue a 'timeupdate' event if we haven't already posted one at the current
     // movie time.
     scheduleTimeupdateEvent(false);
 
     double now = currentTime();
     double dur = duration();
 
@@ skipping 882 matching lines @@
     visitor->trace(m_error);
     visitor->trace(m_currentSourceNode);
     visitor->trace(m_nextChildNodeToConsider);
     visitor->trace(m_textTracks);
     visitor->trace(m_textTracksWhenResourceSelectionBegan);
     WillBeHeapSupplementable<HTMLMediaElement>::trace(visitor);
     HTMLElement::trace(visitor);
 }
 
 }