Record RenderViewContextMenu.Used histogram for commands handled by observers.

Record RenderViewContextMenu.Used histogram for commands handled by observers.
Added UMA constant for counting IDC_SPELLCHECK_SUGGESTION_*.

TBR=asvitkine
BUG=378933
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273817

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274161

[Avi (use Gerrit), 2014-05-30 01:12:40]

LGTM

Oops.

[Vitaly Buka (NO REVIEWS), 2014-05-30 07:48:44]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2014-05-30 07:50:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/306103002/1

[commit-bot: I haz the power, 2014-05-30 13:17:03]

Change committed as 273817

[please use gerrit instead, 2014-06-01 19:39:41]

This hits a NOTREACHED() in RecordUsedItem(id) when selecting spellcheck
suggestions for misspelled words. (Spellcheck is a menu observer.) Instead of
reverting, I will land a separate patch with a unit test to avoid accidental
regressions.

[Vitaly Buka (NO REVIEWS), 2014-06-01 21:43:24]

On 2014/06/01 19:39:41, Rouslan Solomakhin wrote:
> This hits a NOTREACHED() in RecordUsedItem(id) when selecting spellcheck
> suggestions for misspelled words. (Spellcheck is a menu observer.) Instead of
> reverting, I will land a separate patch with a unit test to avoid accidental
> regressions.

NOTREACHED is there exactly to remind to extend kUmaEnumToControlId
Maybe we will need to put other commands later.

[Vitaly Buka (NO REVIEWS), 2014-06-01 21:43:44]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2014-06-01 21:43:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/306103002/60001

[commit-bot: I haz the power, 2014-06-02 05:31:14]

Change committed as 274161

[Alexei Svitkine (slow), 2014-06-02 15:29:15]

lgtm