Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 Test that layers can be nicely added or removed from a squashed layer, without u nnecessary repaints on any layer. Click anywhere to test interactively; keep cli cking to proceed through the test. | 1 Test that layers can be nicely added or removed from a squashed layer, without u nnecessary repaints on any layer. Click anywhere to test interactively; keep cli cking to proceed through the test. |
| 2 | 2 |
| 3 CASE 1, original layer tree with overlap1 and overlap2: | 3 CASE 1, original layer tree with overlap1 and overlap2: |
| 4 (GraphicsLayer | 4 (GraphicsLayer |
| 5 (bounds 800.00 600.00) | 5 (bounds 800.00 600.00) |
| 6 (children 1 | 6 (children 1 |
| 7 (GraphicsLayer | 7 (GraphicsLayer |
| 8 (bounds 800.00 600.00) | 8 (bounds 800.00 600.00) |
| 9 (contentsOpaque 1) | 9 (contentsOpaque 1) |
| 10 (drawsContent 1) | 10 (drawsContent 1) |
| (...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 48 (bounds 400.00 400.00) | 48 (bounds 400.00 400.00) |
| 49 (contentsOpaque 1) | 49 (contentsOpaque 1) |
| 50 (drawsContent 1) | 50 (drawsContent 1) |
| 51 (backgroundColor #808080) | 51 (backgroundColor #808080) |
| 52 ) | 52 ) |
| 53 (GraphicsLayer | 53 (GraphicsLayer |
| 54 (position 140.00 140.00) | 54 (position 140.00 140.00) |
| 55 (bounds 260.00 260.00) | 55 (bounds 260.00 260.00) |
| 56 (drawsContent 1) | 56 (drawsContent 1) |
| 57 (repaint rects | 57 (repaint rects |
| 58 (rect 140.00 140.00 40.00 40.00) | |
| 58 (rect 80.00 80.00 100.00 100.00) | 59 (rect 80.00 80.00 100.00 100.00) |
| 59 (rect 0.00 0.00 100.00 100.00) | 60 (rect 0.00 0.00 100.00 100.00) |
| 60 (rect 0.00 0.00 100.00 100.00) | 61 (rect 0.00 0.00 100.00 100.00) |
| 61 (rect 0.00 0.00 100.00 100.00) | |
| 62 ) | 62 ) |
| 63 ) | 63 ) |
| 64 ) | 64 ) |
| 65 ) | 65 ) |
| 66 ) | 66 ) |
| 67 ) | 67 ) |
| 68 ) | 68 ) |
| 69 ) | 69 ) |
| 70 CASE 3, overlap2 gets removed. Since this does not resize the layer, there shoul d only be a repaint of overlap2: | 70 CASE 3, overlap2 gets removed. Since this does not resize the layer, there shoul d only be a repaint of overlap2: |
| 71 (GraphicsLayer | 71 (GraphicsLayer |
| (...skipping 13 matching lines...) Expand all Loading... | |
| 85 (drawsContent 1) | 85 (drawsContent 1) |
| 86 (backgroundColor #808080) | 86 (backgroundColor #808080) |
| 87 ) | 87 ) |
| 88 (GraphicsLayer | 88 (GraphicsLayer |
| 89 (position 140.00 140.00) | 89 (position 140.00 140.00) |
| 90 (bounds 260.00 260.00) | 90 (bounds 260.00 260.00) |
| 91 (drawsContent 1) | 91 (drawsContent 1) |
| 92 (repaint rects | 92 (repaint rects |
| 93 (rect 160.00 160.00 100.00 100.00) | 93 (rect 160.00 160.00 100.00 100.00) |
| 94 (rect 80.00 80.00 100.00 100.00) | 94 (rect 80.00 80.00 100.00 100.00) |
| 95 (rect 0.00 0.00 100.00 100.00) | |
|
chrishtr
2014/05/30 16:28:05
Not sure why this went away exactly, but (80 80 10
| |
| 96 ) | 95 ) |
| 97 ) | 96 ) |
| 98 ) | 97 ) |
| 99 ) | 98 ) |
| 100 ) | 99 ) |
| 101 ) | 100 ) |
| 102 ) | 101 ) |
| 103 ) | 102 ) |
| 104 CASE 4, overlap1 gets removed: | 103 CASE 4, overlap1 gets removed: |
| 105 (GraphicsLayer | 104 (GraphicsLayer |
| (...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 193 ) | 192 ) |
| 194 (GraphicsLayer | 193 (GraphicsLayer |
| 195 (position 140.00 140.00) | 194 (position 140.00 140.00) |
| 196 (bounds 180.00 180.00) | 195 (bounds 180.00 180.00) |
| 197 (drawsContent 1) | 196 (drawsContent 1) |
| 198 (repaint rects | 197 (repaint rects |
| 199 (rect 80.00 80.00 100.00 100.00) | 198 (rect 80.00 80.00 100.00 100.00) |
| 200 (rect 0.00 0.00 100.00 100.00) | 199 (rect 0.00 0.00 100.00 100.00) |
| 201 (rect 0.00 0.00 100.00 100.00) | 200 (rect 0.00 0.00 100.00 100.00) |
| 202 (rect 0.00 0.00 100.00 100.00) | 201 (rect 0.00 0.00 100.00 100.00) |
| 202 (rect 0.00 0.00 20.00 20.00) | |
|
chrishtr
2014/05/30 16:28:05
This is the amount that overlap1 leaked into the n
| |
| 203 ) | 203 ) |
| 204 ) | 204 ) |
| 205 ) | 205 ) |
| 206 ) | 206 ) |
| 207 ) | 207 ) |
| 208 ) | 208 ) |
| 209 ) | 209 ) |
| 210 ) | 210 ) |
| 211 | 211 |
| OLD | NEW |