LayoutTests/compositing/squashing/invalidations-with-large-negative-margin.html - Issue 306093002: Use the correct method for computing a repaint rect that takes into account squashing.

Side by Side Diff: LayoutTests/compositing/squashing/invalidations-with-large-negative-margin.html

Issue 306093002: Use the correct method for computing a repaint rect that takes into account squashing. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix typo. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/compositing/squashing/add-remove-squashed-layers-expected.txt ('k') | LayoutTests/compositing/squashing/tricky-element-removal-crash-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <div style="height:200px;width:600px;overflow:scroll">

	3 <div style="position:relative">

	4 <div style="height:400px;margin-bottom:-400px;position:relative">

	5 <div id="chip" style="width:50px;height:50px;position:absolute;background: lightblue;margin:0"></div>

	6 </div>

	7 </div>

	8 </div>

	9

	10 <div id="testResults" style="display:none">
	ojan 2014/06/02 05:29:06 Why have the extra outer div? Why not just put the Why have the extra outer div? Why not just put the display:none on the pre itself? chrishtr 2014/06/02 16:22:32 Done. Show quoted text On 2014/06/02 05:29:06, ojan wrote: > Why have the extra outer div? Why not just put the display:none on the pre > itself? Done.
	11 <pre id="output"></pre>

	12 </div>

	13 <script>

	14 // Test that moving a div in this situation generates the correct repaint invali daitons before and after

	15 // the move.
	ojan 2014/06/02 05:29:06 This comment doesn't really say anything that isn' This comment doesn't really say anything that isn't obvious in the test. The sorts of comments that are useful are the ones that say what the "this situation" is that's being tested. It's clear from the test itself that it's verifying repaint invalidations. chrishtr 2014/06/02 16:22:32 Done. Show quoted text On 2014/06/02 05:29:06, ojan wrote: > This comment doesn't really say anything that isn't obvious in the test. The > sorts of comments that are useful are the ones that say what the "this > situation" is that's being tested. It's clear from the test itself that it's > verifying repaint invalidations. Done.
	16 if (window.testRunner) {

	17 testRunner.dumpAsText();

	18 testRunner.waitUntilDone();

	19 window.internals.settings.setLayerSquashingEnabled(true);

	20 }

	21 setTimeout(function() {
	ojan 2014/06/02 05:29:06 Why the setTimeout? setTimeouts lead to slow/flaky Why the setTimeout? setTimeouts lead to slow/flaky tests. chrishtr 2014/06/02 16:22:32 Done. Show quoted text On 2014/06/02 05:29:06, ojan wrote: > Why the setTimeout? setTimeouts lead to slow/flaky tests. Done.
	22 if (window.internals)
	ojan 2014/06/02 05:29:06 Having this if-check, but not checking it in the o Having this if-check, but not checking it in the other places you check window.internals seems kind of random. chrishtr 2014/06/02 16:22:32 Done. Show quoted text On 2014/06/02 05:29:06, ojan wrote: > Having this if-check, but not checking it in the other places you check > window.internals seems kind of random. Done.
	23 window.internals.startTrackingRepaints(document);

	24

	25 document.getElementById('chip').style.left = "400px";

	26 var data = window.internals.layerTreeAsText(document, internals.LAYER_TREE_I NCLUDES_REPAINT_RECTS);

	27 window.internals.stopTrackingRepaints(document);

	28

	29 document.getElementById('output').textContent = data;

	30

	31 document.getElementById('testResults').style.display = "block";

	32

	33 if (window.testRunner)

	34 testRunner.notifyDone();

	35 }, 400);

	36 </script>

OLD	NEW