Replace the HomeCard by the AppList in Athena.

Replace the HomeCard by the AppList in Athena.

BUG=370204
R=oshima@chromium.org, benwells@chromium.org
TBR=reed@google.com
TEST=manually

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274942

[oshima, 2014-05-31 14:30:35]

lgtm with nits

https://codereview.chromium.org/306083005/diff/1/athena/home/app_list_view_de...
File athena/home/app_list_view_delegate.cc (right):

https://codereview.chromium.org/306083005/diff/1/athena/home/app_list_view_de...
athena/home/app_list_view_delegate.cc:70: gfx::ImageSkia GetIcon() {
const

https://codereview.chromium.org/306083005/diff/1/athena/home/app_list_view_de...
athena/home/app_list_view_delegate.cc:237: }
// namespace athena

[Jun Mukai, 2014-06-02 01:44:28]

https://codereview.chromium.org/306083005/diff/1/athena/home/app_list_view_de...
File athena/home/app_list_view_delegate.cc (right):

https://codereview.chromium.org/306083005/diff/1/athena/home/app_list_view_de...
athena/home/app_list_view_delegate.cc:70: gfx::ImageSkia GetIcon() {
On 2014/05/31 14:30:35, oshima wrote:
> const

Done.

https://codereview.chromium.org/306083005/diff/1/athena/home/app_list_view_de...
athena/home/app_list_view_delegate.cc:237: }
On 2014/05/31 14:30:35, oshima wrote:
> // namespace athena

Done.

[Jun Mukai, 2014-06-02 01:45:04]

benwells, could you take a look?

[Jun Mukai, 2014-06-02 17:11:02]

or xiyuan?  Adding new DEPS requires me to get LGTM from the owner of the
depending module.

For AppList, I want someone to review the code because it adds a new
AppListViewDelegate.

[xiyuan, 2014-06-02 17:24:34]

LGTM

https://codereview.chromium.org/306083005/diff/20001/athena/home/app_list_vie...
File athena/home/app_list_view_delegate.cc (right):

https://codereview.chromium.org/306083005/diff/20001/athena/home/app_list_vie...
athena/home/app_list_view_delegate.cc:111:
model_->search_box()->SetHintText(base::ASCIIToUTF16("Search"));
Is it possible to use strings from resource? If not, maybe add a TODO to clean
it up.

https://codereview.chromium.org/306083005/diff/20001/athena/home/app_list_vie...
File athena/home/app_list_view_delegate.h (right):

https://codereview.chromium.org/306083005/diff/20001/athena/home/app_list_vie...
athena/home/app_list_view_delegate.h:22: virtual bool ForceNativeDesktop() const
OVERRIDE;
nit: #include "base/macros.h" for OVERRIDE

https://codereview.chromium.org/306083005/diff/20001/athena/home/home_card_im...
File athena/home/home_card_impl.cc (right):

https://codereview.chromium.org/306083005/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:108: pagination_model_.get(),
fyi, https://codereview.chromium.org/302803002/ is moving PaginationModel into
AppsGridView.

[Jun Mukai, 2014-06-02 17:37:36]

https://codereview.chromium.org/306083005/diff/20001/athena/home/app_list_vie...
File athena/home/app_list_view_delegate.cc (right):

https://codereview.chromium.org/306083005/diff/20001/athena/home/app_list_vie...
athena/home/app_list_view_delegate.cc:111:
model_->search_box()->SetHintText(base::ASCIIToUTF16("Search"));
On 2014/06/02 17:24:34, xiyuan wrote:
> Is it possible to use strings from resource? If not, maybe add a TODO to clean
> it up.

Athena still doesn't have its own resources, and cannot depend on chrome. 
Adding a TODO

https://codereview.chromium.org/306083005/diff/20001/athena/home/app_list_vie...
File athena/home/app_list_view_delegate.h (right):

https://codereview.chromium.org/306083005/diff/20001/athena/home/app_list_vie...
athena/home/app_list_view_delegate.h:22: virtual bool ForceNativeDesktop() const
OVERRIDE;
On 2014/06/02 17:24:34, xiyuan wrote:
> nit: #include "base/macros.h" for OVERRIDE

Done.

https://codereview.chromium.org/306083005/diff/20001/athena/home/home_card_im...
File athena/home/home_card_impl.cc (right):

https://codereview.chromium.org/306083005/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:108: pagination_model_.get(),
On 2014/06/02 17:24:34, xiyuan wrote:
> fyi, https://codereview.chromium.org/302803002/ is moving PaginationModel into
> AppsGridView.

Good to know. Then it's better to wait for that landed and remove
pagination_model_.

[benwells, 2014-06-02 23:17:47]

new dep on app list lgtm ++++

https://codereview.chromium.org/306083005/diff/60001/athena/home/app_list_vie...
File athena/home/app_list_view_delegate.h (right):

https://codereview.chromium.org/306083005/diff/60001/athena/home/app_list_vie...
athena/home/app_list_view_delegate.h:26: virtual app_list::SigninDelegate*
GetSigninDelegate() OVERRIDE;
Note the SigninDelegate is about to disappear.

[Jun Mukai, 2014-06-03 00:21:50]

Updated the initialization of focus / activation controller (required for
athena). I believe this doesn't break anything of app_shell.

https://codereview.chromium.org/306083005/diff/60001/athena/home/app_list_vie...
File athena/home/app_list_view_delegate.h (right):

https://codereview.chromium.org/306083005/diff/60001/athena/home/app_list_vie...
athena/home/app_list_view_delegate.h:26: virtual app_list::SigninDelegate*
GetSigninDelegate() OVERRIDE;
On 2014/06/02 23:17:47, benwells wrote:
> Note the SigninDelegate is about to disappear.

Is there any ongoing CL or is that a plan for now?

[Jun Mukai, 2014-06-03 00:27:15]

On 2014/06/03 00:21:50, Jun Mukai wrote:
> Updated the initialization of focus / activation controller (required for
> athena). I believe this doesn't break anything of app_shell.
> 
>
https://codereview.chromium.org/306083005/diff/60001/athena/home/app_list_vie...
> File athena/home/app_list_view_delegate.h (right):
> 
>
https://codereview.chromium.org/306083005/diff/60001/athena/home/app_list_vie...
> athena/home/app_list_view_delegate.h:26: virtual app_list::SigninDelegate*
> GetSigninDelegate() OVERRIDE;
> On 2014/06/02 23:17:47, benwells wrote:
> > Note the SigninDelegate is about to disappear.
> 
> Is there any ongoing CL or is that a plan for now?

Oops, I misunderstood the CL.  It's better to extract the change of
shell_desktop_controller as another CL.

[benwells, 2014-06-03 00:30:49]

On 2014/06/03 00:21:50, Jun Mukai wrote:
> Updated the initialization of focus / activation controller (required for
> athena). I believe this doesn't break anything of app_shell.
> 
>
https://codereview.chromium.org/306083005/diff/60001/athena/home/app_list_vie...
> File athena/home/app_list_view_delegate.h (right):
> 
>
https://codereview.chromium.org/306083005/diff/60001/athena/home/app_list_vie...
> athena/home/app_list_view_delegate.h:26: virtual app_list::SigninDelegate*
> GetSigninDelegate() OVERRIDE;
> On 2014/06/02 23:17:47, benwells wrote:
> > Note the SigninDelegate is about to disappear.
> 
> Is there any ongoing CL or is that a plan for now?

https://codereview.chromium.org/309443002/

hopefully it will land today. If this lands first I'll rebase and update athena.

[Jun Mukai, 2014-06-03 00:56:12]

On 2014/06/03 00:30:49, benwells wrote:
> On 2014/06/03 00:21:50, Jun Mukai wrote:
> > Updated the initialization of focus / activation controller (required for
> > athena). I believe this doesn't break anything of app_shell.
> > 
> >
>
https://codereview.chromium.org/306083005/diff/60001/athena/home/app_list_vie...
> > File athena/home/app_list_view_delegate.h (right):
> > 
> >
>
https://codereview.chromium.org/306083005/diff/60001/athena/home/app_list_vie...
> > athena/home/app_list_view_delegate.h:26: virtual app_list::SigninDelegate*
> > GetSigninDelegate() OVERRIDE;
> > On 2014/06/02 23:17:47, benwells wrote:
> > > Note the SigninDelegate is about to disappear.
> > 
> > Is there any ongoing CL or is that a plan for now?
> 
> https://codereview.chromium.org/309443002/
> 
> hopefully it will land today. If this lands first I'll rebase and update
athena.

Okay, then I'll wait for that land. thanks.

[Jun Mukai, 2014-06-04 18:04:22]

TBR=reed for adding the deps of third_party/skia

[Jun Mukai, 2014-06-04 18:04:26]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-06-04 18:05:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/306083005/140001

[commit-bot: I haz the power, 2014-06-04 22:40:13]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)

[commit-bot: I haz the power, 2014-06-04 22:46:18]

Change committed as 274942

[Marijn Kruisselbrink, 2014-06-04 23:36:54]

A revert of this CL has been created in
https://codereview.chromium.org/319603004/ by mek@chromium.org.

The reason for reverting is: Seems to break compilation on Linux Chromium OS
ASan LSan Builder:
FAILED: /mnt/data/b/build/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,-z,now -Wl,-z,relro
-Wl,--fatal-warnings -pthread -Wl,-z,noexecstack -fPIC
-B/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Builder/build/src/third_party/binutils/Linux_x64/Release/bin
-Wl,--disable-new-dtags -L. -Wl,-u_sanitizer_options_link_helper -m64
-fsanitize=address -fsanitize=leak -Wl,--icf=none -Wl,-O1 -Wl,--gc-sections -o
athena_shell -Wl,--start-group obj/athena/main/athena_shell.athena_shell.o
obj/athena/main/athena_shell.sample_activity.o obj/base/libsanitizer_options.a
obj/base/libbase.a obj/base/libbase_i18n.a obj/ui/accessibility/libax_gen.a
obj/ui/aura/libaura.a obj/ui/compositor/libcompositor_test_support.a
obj/ui/gfx/libgfx.a obj/athena/libathena_lib.a
obj/athena/libathena_test_support.a obj/base/libbase_static.a
obj/base/allocator/liballocator_extension_thunks.a
obj/third_party/modp_b64/libmodp_b64.a
obj/base/third_party/dynamic_annotations/libdynamic_annotations.a
obj/base/libsymbolize.a obj/base/libxdg_mime.a
obj/third_party/libevent/libevent.a obj/third_party/icu/libicui18n.a
obj/third_party/icu/libicuuc.a obj/third_party/icu/libicudata.a
obj/skia/libskia_library.a obj/skia/libskia_opts.a obj/skia/libskia_opts_ssse3.a
obj/third_party/zlib/libchrome_zlib.a obj/third_party/sfntly/libsfntly.a
obj/skia/libskia_chrome.a obj/skia/libskia_chrome_opts.a
obj/tools/json_schema_compiler/libapi_gen_util.a obj/ui/base/libui_base.a
obj/net/libnet.a obj/crypto/libcrcrypto.a obj/net/third_party/nss/libcrssl.a
obj/sdch/libsdch.a obj/url/liburl_lib.a obj/ui/events/libevents_base.a
obj/third_party/harfbuzz-ng/libharfbuzz-ng.a obj/third_party/libpng/libpng.a
obj/ui/gfx/libgfx_geometry.a obj/third_party/libjpeg/libjpeg.a
obj/ui/gfx/x/libgfx_x11.a obj/ui/events/libdom4_keycode_converter.a
obj/ui/events/platform/libevents_platform.a obj/ui/events/libevents.a
obj/ui/events/libgesture_detection.a obj/chromeos/libchromeos.a
obj/base/libbase_prefs.a obj/components/libcloud_policy_proto.a
obj/third_party/protobuf/libprotobuf_lite.a obj/components/libonc_component.a
obj/dbus/libdbus.a obj/third_party/libxml/libxml2.a
obj/chromeos/libcryptohome_proto.a obj/chromeos/libpower_manager_proto.a
obj/ui/events/platform/x11/libx11_events_platform.a
obj/ui/compositor/libcompositor.a obj/cc/libcc.a
obj/gpu/libcommand_buffer_client.a obj/gpu/libcommand_buffer_common.a
obj/gpu/command_buffer/libgles2_utils.a obj/gpu/libcommand_buffer_service.a
obj/gpu/libdisk_cache_proto.a obj/third_party/re2/libre2.a
obj/third_party/smhasher/libcityhash.a obj/ui/gl/libgl_wrapper.a
obj/third_party/angle/src/libtranslator.a
obj/third_party/angle/src/libtranslator_lib.a
obj/third_party/angle/src/libpreprocessor.a obj/gpu/libgles2_cmd_helper.a
obj/gpu/libgpu_config.a obj/build/linux/libpci.a
obj/third_party/libXNVCtrl/libXNVCtrl.a obj/gpu/libgpu_ipc.a obj/ipc/libipc.a
obj/media/libmedia.a obj/third_party/opus/libopus.a
obj/media/libshared_memory_support.a obj/third_party/ffmpeg/libffmpeg.a
obj/third_party/libvpx/libvpx.a obj/third_party/libvpx/libvpx_asm_offsets_vp8.a
obj/third_party/libvpx/libvpx_intrinsics_mmx.a
obj/third_party/libvpx/libvpx_intrinsics_sse2.a
obj/third_party/libvpx/libvpx_intrinsics_ssse3.a libyuv.a
obj/third_party/libjpeg_turbo/libjpeg_turbo.a obj/media/libmedia_asm.a
obj/media/libmedia_mmx.a obj/media/libmedia_sse2.a obj/cc/libcc_test_support.a
obj/gpu/libgles2_c_lib.a obj/gpu/libgles2_implementation.a
obj/gpu/libgl_in_process_context.a obj/gpu/libgpu_unittest_utils.a
obj/testing/libgmock.a obj/testing/libgtest.a obj/ui/gl/libgl_unittest_utils.a
obj/gpu/skia_bindings/libgpu_skia_bindings.a obj/ui/gfx/libgfx_test_support.a
obj/third_party/WebKit/Source/platform/libblink_common.a
obj/third_party/WebKit/Source/wtf/libwtf.a obj/webkit/common/gpu/libwebkit_gpu.a
obj/ui/app_list/libapp_list.a obj/ui/wm/libwm.a obj/content/libcontent_browser.a
obj/content/libcontent_common.a obj/components/libtracing.a
obj/third_party/libjingle/libjingle.a
obj/third_party/libjingle/libjingle_p2p_constants.a
obj/ui/accessibility/libaccessibility.a obj/ui/events/ipc/libevents_ipc.a
obj/ui/shell_dialogs/libshell_dialogs.a obj/mojo/libmojo_environment_chromium.a
obj/mojo/libmojo_common_lib.a obj/mojo/libmojo_system_impl.a
obj/mojo/libmojo_environment_chromium_impl.a
obj/third_party/WebKit/Source/platform/libblink_platform.a
obj/third_party/WebKit/Source/platform/libblink_heap_asm_stubs.a
obj/third_party/libwebp/libwebp_dec.a obj/third_party/libwebp/libwebp_dsp.a
obj/third_party/libwebp/libwebp_utils.a obj/third_party/libwebp/libwebp_demux.a
obj/third_party/libwebp/libwebp_enc.a obj/third_party/ots/libots.a
obj/third_party/brotli/libbrotli.a obj/third_party/qcms/libqcms.a
obj/v8/tools/gyp/libv8_base.a obj/v8/tools/gyp/libv8_snapshot.a
obj/third_party/iccjpeg/libiccjpeg.a
obj/third_party/WebKit/Source/web/libblink_web.a
obj/third_party/WebKit/Source/core/libwebcore_dom.a
obj/third_party/libxslt/libxslt.a obj/third_party/sqlite/libsqlite3.a
obj/third_party/WebKit/Source/core/libwebcore_html.a
obj/third_party/WebKit/Source/core/libwebcore_remaining.a
obj/third_party/WebKit/Source/core/libwebcore_rendering.a
obj/third_party/WebKit/Source/core/libwebcore_svg.a
obj/third_party/WebKit/Source/core/libwebcore_generated.a obj/gin/libgin.a
obj/third_party/WebKit/Source/modules/libmodules.a
obj/webkit/common/libwebkit_common.a obj/webkit/libwebkit_storage_browser.a
obj/sql/libsql.a obj/third_party/leveldatabase/libleveldatabase.a
obj/third_party/snappy/libsnappy.a obj/webkit/libwebkit_storage_common.a
obj/ppapi/libppapi_shared.a obj/ui/surface/libsurface.a
obj/google_apis/libgoogle_apis.a obj/third_party/zlib/google/libzip.a
obj/third_party/zlib/libminizip.a obj/ui/snapshot/libsnapshot.a
obj/content/browser/service_worker/libdatabase_proto.a
obj/content/browser/speech/proto/libspeech_proto.a
obj/content/libcontent_common_mojo_bindings.a obj/mojo/libmojo_cpp_bindings.a
obj/cc/libcc_surfaces.a obj/mojo/libmojo_js_bindings.a
obj/mojo/libmojo_service_provider_bindings.a obj/net/libhttp_server.a
obj/printing/libprinting.a obj/sandbox/libsandbox_services.a
obj/sandbox/libsuid_sandbox_client.a obj/sandbox/libseccomp_bpf.a
obj/sandbox/libseccomp_bpf_helpers.a obj/jingle/libjingle_glue.a
obj/third_party/libjingle/libjingle_webrtc.a
obj/third_party/libjingle/libjingle_webrtc_common.a
obj/third_party/libsrtp/libsrtp.a obj/third_party/webrtc/modules/libmedia_file.a
obj/third_party/webrtc/system_wrappers/source/libsystem_wrappers.a
obj/third_party/webrtc/base/libwebrtc_base.a
obj/third_party/webrtc/modules/libvideo_capture_module.a
obj/third_party/webrtc/modules/libwebrtc_utility.a
obj/third_party/webrtc/modules/libaudio_coding_module.a
obj/third_party/webrtc/modules/libCNG.a
obj/third_party/webrtc/common_audio/libcommon_audio.a
obj/third_party/webrtc/common_audio/libcommon_audio_sse2.a
obj/third_party/webrtc/modules/libG711.a
obj/third_party/webrtc/modules/libG722.a
obj/third_party/webrtc/modules/libiLBC.a
obj/third_party/webrtc/modules/libiSAC.a
obj/third_party/webrtc/modules/libiSACFix.a
obj/third_party/webrtc/modules/libPCM16B.a
obj/third_party/webrtc/modules/libwebrtc_opus.a
obj/third_party/webrtc/modules/libNetEq4.a
obj/third_party/webrtc/modules/libwebrtc_video_coding.a
obj/third_party/webrtc/modules/libwebrtc_i420.a
obj/third_party/webrtc/common_video/libcommon_video.a
obj/third_party/webrtc/modules/video_coding/utility/libvideo_coding_utility.a
obj/third_party/webrtc/modules/video_coding/codecs/vp8/libwebrtc_vp8.a
obj/third_party/webrtc/modules/libvideo_render_module.a
obj/third_party/usrsctp/libusrsctplib.a
obj/third_party/webrtc/modules/libdesktop_capture.a
obj/third_party/webrtc/modules/libdesktop_capture_differ_sse2.a
obj/sandbox/libc_urandom_override.a obj/ppapi/libppapi_ipc.a
obj/third_party/flac/libflac.a obj/third_party/speex/libspeex.a
obj/ui/views/controls/webview/libwebview.a obj/ui/web_dialogs/libweb_dialogs.a
obj/ui/views/libviews.a obj/ui/native_theme/libnative_theme.a
obj/base/libtest_support_base.a obj/ui/aura/libaura_test_support.a
obj/ui/base/libui_base_test_support.a obj/ui/events/libevents_test_support.a 
-Wl,--end-group -lrt -ldl -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lglib-2.0
-lfontconfig -lfreetype -lpangocairo-1.0 -lcairo -lpangoft2-1.0 -lpango-1.0
-lnss3 -lnssutil3 -lsmime3 -lplds4 -lplc4 -lnspr4 -lresolv -lX11 -lXi -ldbus-1
-lpthread -lXcursor -lXext -lXfixes -lXrender -lXcomposite -lasound -lXdamage
-lXtst -lXrandr -lexpat -lcap -lcrypto -lm -ludev
../../content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc:61:error:
undefined reference to 'ppapi::host::PpapiHost::PpapiHost(IPC::Sender*,
ppapi::PpapiPermissions const&)'
../../content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc:63:error:
undefined reference to
'ppapi::host::PpapiHost::AddHostFactoryFilter(scoped_ptr<ppapi::host::HostFactory,
base::DefaultDeleter<ppapi::host::HostFactory> >)'
[etc...].