Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc

Issue 306083002: Fixing problem with minimizing of applications to incorrect locations (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing problem with settings application Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc
diff --git a/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc b/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc
index d35a1f80ef82229bde061b7759b98624c76c919b..b95da14d8f074ac5cd3485e2467ed9955956c58d 100644
--- a/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc
+++ b/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc
@@ -103,8 +103,14 @@ void BrowserShortcutLauncherItemController::UpdateBrowserItemState() {
void BrowserShortcutLauncherItemController::SetShelfIDForBrowserWindowContents(
Browser* browser,
content::WebContents* web_contents) {
- if (!IsBrowserRepresentedInBrowserList(browser))
+ // We need to call SetShelfIDForWindow for V1 applications since they are
+ // content which might change and as such change the application type.
+ if (!browser ||
+ !launcher_controller()->IsBrowserFromActiveUser(browser) ||
+ browser->host_desktop_type() != chrome::HOST_DESKTOP_TYPE_ASH ||
+ chrome::IsTrustedPopupWindowWithScheme(browser, content::kChromeUIScheme))
return;
+
ash::SetShelfIDForWindow(
launcher_controller()->GetShelfIDForWebContents(web_contents),
browser->window()->GetNativeWindow());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698