Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 306073007: [Drive] Fetch id field of the parents in FileResource. (Closed)

Created:
6 years, 6 months ago by tzik
Modified:
6 years, 6 months ago
Reviewers:
hashimoto
CC:
chromium-reviews
Visibility:
Public.

Description

[Drive] Fetch id field of the parents in FileResource. BUG=379667 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274437

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : fix fields syntax #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M chrome/browser/drive/drive_api_service.cc View 1 2 3 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
tzik
PTL
6 years, 6 months ago (2014-06-02 08:08:12 UTC) #1
hashimoto
https://codereview.chromium.org/306073007/diff/1/chrome/browser/drive/drive_api_service.cc File chrome/browser/drive/drive_api_service.cc (right): https://codereview.chromium.org/306073007/diff/1/chrome/browser/drive/drive_api_service.cc#newcode117 chrome/browser/drive/drive_api_service.cc:117: "parents/parentLink,alternateLink," Please add "id" here too. https://codereview.chromium.org/306073007/diff/1/chrome/browser/drive/drive_api_service.cc#newcode123 chrome/browser/drive/drive_api_service.cc:123: "parents/parentLink,alternateLink,modifiedDate,lastViewedByMeDate,shared)," ...
6 years, 6 months ago (2014-06-02 08:09:52 UTC) #2
tzik
https://codereview.chromium.org/306073007/diff/1/chrome/browser/drive/drive_api_service.cc File chrome/browser/drive/drive_api_service.cc (right): https://codereview.chromium.org/306073007/diff/1/chrome/browser/drive/drive_api_service.cc#newcode117 chrome/browser/drive/drive_api_service.cc:117: "parents/parentLink,alternateLink," On 2014/06/02 08:09:53, hashimoto wrote: > Please add ...
6 years, 6 months ago (2014-06-02 08:13:00 UTC) #3
hashimoto
lgtm
6 years, 6 months ago (2014-06-02 08:13:37 UTC) #4
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 6 months ago (2014-06-02 08:14:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/306073007/20001
6 years, 6 months ago (2014-06-02 08:14:55 UTC) #6
tzik
The CQ bit was unchecked by tzik@chromium.org
6 years, 6 months ago (2014-06-02 08:22:23 UTC) #7
tzik
Fixed |fields| parameter syntax. Could you take another look?
6 years, 6 months ago (2014-06-02 08:30:40 UTC) #8
hashimoto
sorry, I should have noticed it. lgtm
6 years, 6 months ago (2014-06-02 08:32:11 UTC) #9
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 6 months ago (2014-06-02 08:34:38 UTC) #10
tzik
The CQ bit was unchecked by tzik@chromium.org
6 years, 6 months ago (2014-06-02 08:34:39 UTC) #11
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 6 months ago (2014-06-02 08:35:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/306073007/40001
6 years, 6 months ago (2014-06-02 08:35:19 UTC) #13
tzik
The CQ bit was unchecked by tzik@chromium.org
6 years, 6 months ago (2014-06-02 08:36:03 UTC) #14
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 6 months ago (2014-06-02 15:25:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/306073007/40001
6 years, 6 months ago (2014-06-02 15:25:47 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-02 18:23:23 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-02 18:27:12 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/158781) chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/71089) linux_chromium_rel ...
6 years, 6 months ago (2014-06-02 18:27:12 UTC) #19
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 6 months ago (2014-06-03 04:27:28 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/306073007/60001
6 years, 6 months ago (2014-06-03 04:30:02 UTC) #21
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 08:55:16 UTC) #22
Message was sent while issue was closed.
Change committed as 274437

Powered by Google App Engine
This is Rietveld 408576698