|
|
Created:
6 years, 6 months ago by tzik Modified:
6 years, 6 months ago Reviewers:
hashimoto CC:
chromium-reviews Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
Description[Drive] Fetch id field of the parents in FileResource.
BUG=379667
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274437
Patch Set 1 #
Total comments: 4
Patch Set 2 : #Patch Set 3 : fix fields syntax #Patch Set 4 : rebase #Messages
Total messages: 22 (0 generated)
PTL
https://codereview.chromium.org/306073007/diff/1/chrome/browser/drive/drive_a... File chrome/browser/drive/drive_api_service.cc (right): https://codereview.chromium.org/306073007/diff/1/chrome/browser/drive/drive_a... chrome/browser/drive/drive_api_service.cc:117: "parents/parentLink,alternateLink," Please add "id" here too. https://codereview.chromium.org/306073007/diff/1/chrome/browser/drive/drive_a... chrome/browser/drive/drive_api_service.cc:123: "parents/parentLink,alternateLink,modifiedDate,lastViewedByMeDate,shared)," ditto.
https://codereview.chromium.org/306073007/diff/1/chrome/browser/drive/drive_a... File chrome/browser/drive/drive_api_service.cc (right): https://codereview.chromium.org/306073007/diff/1/chrome/browser/drive/drive_a... chrome/browser/drive/drive_api_service.cc:117: "parents/parentLink,alternateLink," On 2014/06/02 08:09:53, hashimoto wrote: > Please add "id" here too. Done. https://codereview.chromium.org/306073007/diff/1/chrome/browser/drive/drive_a... chrome/browser/drive/drive_api_service.cc:123: "parents/parentLink,alternateLink,modifiedDate,lastViewedByMeDate,shared)," On 2014/06/02 08:09:53, hashimoto wrote: > ditto. Done.
lgtm
The CQ bit was checked by tzik@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/306073007/20001
The CQ bit was unchecked by tzik@chromium.org
Fixed |fields| parameter syntax. Could you take another look?
sorry, I should have noticed it. lgtm
The CQ bit was checked by tzik@chromium.org
The CQ bit was unchecked by tzik@chromium.org
The CQ bit was checked by tzik@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/306073007/40001
The CQ bit was unchecked by tzik@chromium.org
The CQ bit was checked by tzik@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/306073007/40001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...) android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...) chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...) linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...) linux_chromium_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...) linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...) linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...) chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...) linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
The CQ bit was checked by tzik@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/306073007/60001
Message was sent while issue was closed.
Change committed as 274437 |