chrome/browser/extensions/api/file_handlers/app_file_handler_util.h - Issue 306073004: Rename "CheckWritable" to "PrepareForWritableApp" to reflect the actual behavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/file_handlers/app_file_handler_util.h

Issue 306073004: Rename "CheckWritable" to "PrepareForWritableApp" to reflect the actual behavior. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed review comments. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_manager/filesystem_api_util.cc ('k') | chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/file_handlers/app_file_handler_util.h

diff --git a/chrome/browser/extensions/api/file_handlers/app_file_handler_util.h b/chrome/browser/extensions/api/file_handlers/app_file_handler_util.h

index 53d003602d3eed3a8343c75a562ff3f99ae3223e..ef43bbf84706c421964a1eac89392c05ec8ea667 100644

--- a/chrome/browser/extensions/api/file_handlers/app_file_handler_util.h

+++ b/chrome/browser/extensions/api/file_handlers/app_file_handler_util.h

@@ -66,7 +66,12 @@ apps::file_handler_util::GrantedFileEntry CreateFileEntry(

const base::FilePath& path,

bool is_directory);

-void CheckWritableFiles(

+// When |is_directory| is true, it verifies that directories exist at each of

+// When |is_directory| is false, it ensures regular files exists (not links and

+// directories) at the |paths|, creating files if needed, and calls back to

+// |on_success| or to |on_failure| depending on the result.

+void PrepareFilesForWritableApp(

const std::vector<base::FilePath>& paths,

Profile* profile,

bool is_directory,