apps/launcher.cc - Issue 306073004: Rename "CheckWritable" to "PrepareForWritableApp" to reflect the actual behavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: apps/launcher.cc

Issue 306073004: Rename "CheckWritable" to "PrepareForWritableApp" to reflect the actual behavior. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed review comments. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: apps/launcher.cc

diff --git a/apps/launcher.cc b/apps/launcher.cc

index acaec4156a77cf2b3005a097fab7065cf4ec475b..f357881ce96de18b4c9ab8848b9391e552245a7e 100644

--- a/apps/launcher.cc

+++ b/apps/launcher.cc

@@ -46,7 +46,7 @@ namespace app_runtime = apps::api::app_runtime;

using apps::file_handler_util::GrantedFileEntry;

using content::BrowserThread;

-using extensions::app_file_handler_util::CheckWritableFiles;

+using extensions::app_file_handler_util::PrepareFilesForWritableApp;

using extensions::app_file_handler_util::FileHandlerForId;

using extensions::app_file_handler_util::FileHandlerCanHandleFile;

using extensions::app_file_handler_util::FirstFileHandlerForFile;

@@ -114,7 +114,7 @@ class PlatformAppPathLauncher

if (HasFileSystemWritePermission(extension_)) {

std::vector<base::FilePath> paths;

paths.push_back(file_path_);

- CheckWritableFiles(

+ PrepareFilesForWritableApp(

paths,

profile_,

false,

« no previous file with comments | « no previous file | chrome/browser/chromeos/file_manager/filesystem_api_util.h » ('j') | no next file with comments »