Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 306063006: Fix: Adding layout test expectations for Android which were left out in r173667 (Closed)

Created:
6 years, 6 months ago by amogh.bihani
Modified:
6 years, 6 months ago
CC:
blink-reviews, prabhur1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Adding layout test expectations for Android which were left out in r173667 This patch fixes the Android layout test failures by adding the test expectations for the new testcases added in https://codereview.chromium.org/267333006/ TEST= ./run_webkit_tests.sh --android http/tests/media/media-source/mediasource-closed.html ./run_webkit_tests.sh --android http/tests/media/media-source/mediasource-is-type-supported.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175335

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M LayoutTests/platform/android/http/tests/media/media-source/mediasource-addsourcebuffer-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/platform/android/http/tests/media/media-source/mediasource-is-type-supported-expected.txt View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
amogh.bihani
PTAL.
6 years, 6 months ago (2014-06-02 11:29:40 UTC) #1
prabhur1
looks fine. Adding Matt as well.
6 years, 6 months ago (2014-06-02 17:32:46 UTC) #2
wolenetz
lgtm
6 years, 6 months ago (2014-06-02 17:48:33 UTC) #3
amogh.bihani
The CQ bit was checked by amogh.bihani@samsung.com
6 years, 6 months ago (2014-06-03 02:56:38 UTC) #4
amogh.bihani
The CQ bit was unchecked by amogh.bihani@samsung.com
6 years, 6 months ago (2014-06-03 02:56:40 UTC) #5
amogh.bihani
The CQ bit was checked by amogh.bihani@samsung.com
6 years, 6 months ago (2014-06-03 03:20:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/amogh.bihani@samsung.com/306063006/1
6 years, 6 months ago (2014-06-03 03:20:55 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-03 04:36:01 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 05:19:42 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/9987)
6 years, 6 months ago (2014-06-03 05:19:43 UTC) #10
amogh.bihani
The CQ bit was checked by amogh.bihani@samsung.com
6 years, 6 months ago (2014-06-03 06:35:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/amogh.bihani@samsung.com/306063006/1
6 years, 6 months ago (2014-06-03 06:36:23 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 06:36:46 UTC) #13
Message was sent while issue was closed.
Change committed as 175335

Powered by Google App Engine
This is Rietveld 408576698