move all code generation under genProgram() in GrGLShaderBuilder.

move all code generation under genProgram() in GrGLShaderBuilder.

Committed: http://code.google.com/p/skia/source/detail?r=14996

[bsalomon, 2014-05-29 22:40:48]

https://codereview.chromium.org/306063002/diff/20001/src/gpu/gl/GrGLShaderBui...
File src/gpu/gl/GrGLShaderBuilder.cpp (right):

https://codereview.chromium.org/306063002/diff/20001/src/gpu/gl/GrGLShaderBui...
src/gpu/gl/GrGLShaderBuilder.cpp:197: fOutput.fColorEffects =
The diff is hard to read. This is mostly a code shuffle. This is where the old
genProgram() began. I dumped the contents of the GrGLShaderBuilder constructor
above here. Then I added calls to emitCode[Before|After]Effects and converted
the input coverage/color members to local vars.  GrGLFullShaderBuilder's
constructor body became its impl for emitCodeBeforeEffects() with the exception
of the rt-adjustment which went to emitCodeAfterEffects().

[robertphillips, 2014-05-30 12:14:13]

lgtm

[jvanverth1, 2014-05-30 12:36:38]

https://codereview.chromium.org/306063002/diff/20001/src/gpu/gl/GrGLShaderBui...
File src/gpu/gl/GrGLShaderBuilder.h (right):

https://codereview.chromium.org/306063002/diff/20001/src/gpu/gl/GrGLShaderBui...
src/gpu/gl/GrGLShaderBuilder.h:319: * execute before the effects' code and/or
emit other shaders (e.g. geometery, vertex).
Typo (geometery)

[bsalomon, 2014-05-30 13:35:49]

https://codereview.chromium.org/306063002/diff/20001/src/gpu/gl/GrGLShaderBui...
File src/gpu/gl/GrGLShaderBuilder.h (right):

https://codereview.chromium.org/306063002/diff/20001/src/gpu/gl/GrGLShaderBui...
src/gpu/gl/GrGLShaderBuilder.h:319: * execute before the effects' code and/or
emit other shaders (e.g. geometery, vertex).
On 2014/05/30 12:36:38, jvanverth1 wrote:
> Typo (geometery)

thanks, will fix before landing.

[bsalomon, 2014-05-30 15:06:27]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-05-30 15:06:41]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bsalomon@google.com/306063002/40001

[commit-bot: I haz the power, 2014-05-30 15:14:59]

Change committed as 14996