Use ExtensionRegistry in developer private api

Use ExtensionRegistry instead of chrome notification in developer private api

BUG=354046
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274478

[limasdf, 2014-06-02 18:24:22]

Devlin, please have a look when you have time.

[Devlin, 2014-06-02 18:41:01]

Just a few quick nits :)

https://codereview.chromium.org/306053013/diff/20002/chrome/browser/extension...
File chrome/browser/extensions/api/developer_private/developer_private_api.cc
(right):

https://codereview.chromium.org/306053013/diff/20002/chrome/browser/extension...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:228:
developer::EventData event_data;
nit: Move this outside switch() to line 225...

https://codereview.chromium.org/306053013/diff/20002/chrome/browser/extension...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:232:
BroadcastItemStateChanged(
... and then put this and the same call on line 241 after the switch ~line 249.

https://codereview.chromium.org/306053013/diff/20002/chrome/browser/extension...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:254:
CHECK(profile_->IsSameProfile(Profile::FromBrowserContext(browser_context)));
probably safe to make these DCHECKs.  Nothing terrible happens if it's not the
same profile (and it definitely should never happen).

[limasdf, 2014-06-02 18:52:36]

Thanks as always :)
I've addressed your comments.
please take a look.

https://codereview.chromium.org/306053013/diff/20002/chrome/browser/extension...
File chrome/browser/extensions/api/developer_private/developer_private_api.cc
(right):

https://codereview.chromium.org/306053013/diff/20002/chrome/browser/extension...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:228:
developer::EventData event_data;
On 2014/06/02 18:41:02, Devlin wrote:
> nit: Move this outside switch() to line 225...

Done.

https://codereview.chromium.org/306053013/diff/20002/chrome/browser/extension...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:232:
BroadcastItemStateChanged(
On 2014/06/02 18:41:02, Devlin wrote:
> ... and then put this and the same call on line 241 after the switch ~line
249.

Done.

[Devlin, 2014-06-02 20:10:19]

lgtm :)

[limasdf, 2014-06-03 01:00:41]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-06-03 01:02:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/limasdf@gmail.com/306053013/90001

[commit-bot: I haz the power, 2014-06-03 05:13:17]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-06-03 07:45:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-03 07:45:02]

Try jobs failed on following builders:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[limasdf, 2014-06-03 07:48:06]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-06-03 07:48:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/limasdf@gmail.com/306053013/90001

[commit-bot: I haz the power, 2014-06-03 12:13:13]

Change committed as 274478