Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: Source/core/inspector/InspectorBaseAgent.h

Issue 306053010: Tried using CrossThreadPersistent for workerDebuggerAgents (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/InspectorBaseAgent.h
diff --git a/Source/core/inspector/InspectorBaseAgent.h b/Source/core/inspector/InspectorBaseAgent.h
index eae8210979a35633618be2aa14522043f1123730..90389ec0925886aa916c475afb0cd3a963ad1653 100644
--- a/Source/core/inspector/InspectorBaseAgent.h
+++ b/Source/core/inspector/InspectorBaseAgent.h
@@ -32,6 +32,7 @@
#define InspectorBaseAgent_h
#include "InspectorBackendDispatcher.h"
+#include "platform/heap/Handle.h"
#include "wtf/Forward.h"
#include "wtf/Vector.h"
#include "wtf/text/WTFString.h"
@@ -43,10 +44,11 @@ class InspectorCompositeState;
class InspectorState;
class InstrumentingAgents;
-class InspectorAgent {
+class InspectorAgent : public NoBaseWillBeGarbageCollectedFinalized<InspectorAgent> {
public:
explicit InspectorAgent(const String&);
virtual ~InspectorAgent();
+ virtual void trace(Visitor*);
virtual void init() { }
virtual void setFrontend(InspectorFrontend*) { }
@@ -61,17 +63,17 @@ public:
void appended(InstrumentingAgents*, InspectorState*);
protected:
- InstrumentingAgents* m_instrumentingAgents;
+ RawPtrWillBeMember<InstrumentingAgents> m_instrumentingAgents;
InspectorState* m_state;
private:
String m_name;
};
-class InspectorAgentRegistry {
+class InspectorAgentRegistry : public NoBaseWillBeGarbageCollectedFinalized<InspectorAgentRegistry> {
public:
InspectorAgentRegistry(InstrumentingAgents*, InspectorCompositeState*);
- void append(PassOwnPtr<InspectorAgent>);
+ void append(PassOwnPtrWillBeRawPtr<InspectorAgent>);
void setFrontend(InspectorFrontend*);
void clearFrontend();
@@ -80,10 +82,12 @@ public:
void discardAgents();
void flushPendingFrontendMessages();
+ void trace(Visitor*);
+
private:
- InstrumentingAgents* m_instrumentingAgents;
+ RawPtrWillBeMember<InstrumentingAgents> m_instrumentingAgents;
InspectorCompositeState* m_inspectorState;
- Vector<OwnPtr<InspectorAgent> > m_agents;
+ WillBeHeapVector<RawPtrWillBeMember<InspectorAgent> > m_agents;
};
template<typename T>
« no previous file with comments | « Source/core/inspector/InspectorApplicationCacheAgent.cpp ('k') | Source/core/inspector/InspectorBaseAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698