Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: components/autofill/core/browser/autofill_manager.h

Issue 306053008: Rename AutofillManagerDelegate to AutofillClient. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_manager.h
diff --git a/components/autofill/core/browser/autofill_manager.h b/components/autofill/core/browser/autofill_manager.h
index 5f84ba951d4b8bcf689491bd59ea2d3ecb8b3ae4..120b14d02a4d439fb230be3c6a7d8d7d88e94824 100644
--- a/components/autofill/core/browser/autofill_manager.h
+++ b/components/autofill/core/browser/autofill_manager.h
@@ -20,9 +20,9 @@
#include "base/strings/string16.h"
#include "base/time/time.h"
#include "components/autofill/core/browser/autocomplete_history_manager.h"
+#include "components/autofill/core/browser/autofill_client.h"
#include "components/autofill/core/browser/autofill_download.h"
#include "components/autofill/core/browser/autofill_driver.h"
-#include "components/autofill/core/browser/autofill_manager_delegate.h"
#include "components/autofill/core/browser/form_structure.h"
#include "components/autofill/core/browser/personal_data_manager.h"
#include "components/autofill/core/common/form_data.h"
@@ -49,7 +49,7 @@ class AutofillDataModel;
class AutofillDownloadManager;
class AutofillExternalDelegate;
class AutofillField;
-class AutofillManagerDelegate;
+class AutofillClient;
class AutofillManagerTestDelegate;
class AutofillMetrics;
class AutofillProfile;
@@ -78,7 +78,7 @@ class AutofillManager : public AutofillDownloadManager::Observer {
#endif // defined(OS_MACOSX) && !defined(OS_IOS)
AutofillManager(AutofillDriver* driver,
- autofill::AutofillManagerDelegate* delegate,
+ AutofillClient* client,
const std::string& app_locale,
AutofillDownloadManagerState enable_download_manager);
virtual ~AutofillManager();
@@ -125,14 +125,12 @@ class AutofillManager : public AutofillDownloadManager::Observer {
// Happens when the autocomplete dialog runs its callback when being closed.
void RequestAutocompleteDialogClosed();
- autofill::AutofillManagerDelegate* delegate() const {
- return manager_delegate_;
- }
+ AutofillClient* client() const { return client_; }
const std::string& app_locale() const { return app_locale_; }
// Only for testing.
- void SetTestDelegate(autofill::AutofillManagerTestDelegate* delegate);
+ void SetTestDelegate(AutofillManagerTestDelegate* delegate);
void OnFormsSeen(const std::vector<FormData>& forms,
const base::TimeTicks& timestamp);
@@ -177,7 +175,7 @@ class AutofillManager : public AutofillDownloadManager::Observer {
protected:
// Test code should prefer to use this constructor.
AutofillManager(AutofillDriver* driver,
- autofill::AutofillManagerDelegate* delegate,
+ AutofillClient* client,
PersonalDataManager* personal_data);
// Uploads the form data to the Autofill server.
@@ -293,7 +291,7 @@ class AutofillManager : public AutofillDownloadManager::Observer {
// outlive this object.
AutofillDriver* driver_;
- autofill::AutofillManagerDelegate* const manager_delegate_;
+ AutofillClient* const client_;
std::string app_locale_;
@@ -345,12 +343,12 @@ class AutofillManager : public AutofillDownloadManager::Observer {
AutofillExternalDelegate* external_delegate_;
// Delegate used in test to get notifications on certain events.
- autofill::AutofillManagerTestDelegate* test_delegate_;
+ AutofillManagerTestDelegate* test_delegate_;
base::WeakPtrFactory<AutofillManager> weak_ptr_factory_;
friend class AutofillManagerTest;
- friend class autofill::FormStructureBrowserTest;
+ friend class FormStructureBrowserTest;
FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
DeterminePossibleFieldTypesForUpload);
FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,

Powered by Google App Engine
This is Rietveld 408576698