Issue 306053005: Adds whitelisted non-extension-based input methods if no component extensions are at present (e.g. …

Issue 306053005: Adds whitelisted non-extension-based input methods if no component extensions are at present (e.g. … (Closed)

Created:
6 years, 6 months ago by Shu Chen

Modified:
6 years, 6 months ago

Reviewers:
Yuki

CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Adds whitelisted non-extension-based input methods if no component extensions are at present (e.g. linux_chromeos). And also clean up some useless code. BUG=364712 TEST=Verified it works on linux_chromeos and no regression on Pixel device. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274589

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : fixed test failures. #

Total comments: 6

Patch Set 6 : #

Patch Set 7 : rebased. #

Patch Set 8 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -276 lines)			Patch
M	chrome/browser/chromeos/input_method/input_method_manager_impl.h	View	1 2 3 4 5 6 7	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_manager_impl.cc	View	1 2 3 4 5 6 7	4 chunks	+16 lines, -15 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util.h	View	1 2 3 4 5 6 7	3 chunks	+7 lines, -13 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util.cc	View	1 2 3 4 5 6 7	9 chunks	+67 lines, -224 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util_unittest.cc	View	1 2 3 4 5 6 7	4 chunks	+6 lines, -23 lines	0 comments	Download
M	chromeos/ime/input_method_whitelist.cc	View	1 2 3 4 5 6	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Yuki

lgtm with nits. https://codereview.chromium.org/306053005/diff/80001/chrome/browser/chromeos/input_method/input_method_manager_impl.cc File chrome/browser/chromeos/input_method/input_method_manager_impl.cc (right): https://codereview.chromium.org/306053005/diff/80001/chrome/browser/chromeos/input_method/input_method_manager_impl.cc#newcode118 chrome/browser/chromeos/input_method/input_method_manager_impl.cc:118: return whitelist_.GetSupportedInputMethods().Pass(); No need to call ...

6 years, 6 months ago (2014-06-02 06:28:52 UTC) #2

Shu Chen

https://codereview.chromium.org/306053005/diff/80001/chrome/browser/chromeos/input_method/input_method_manager_impl.cc File chrome/browser/chromeos/input_method/input_method_manager_impl.cc (right): https://codereview.chromium.org/306053005/diff/80001/chrome/browser/chromeos/input_method/input_method_manager_impl.cc#newcode118 chrome/browser/chromeos/input_method/input_method_manager_impl.cc:118: return whitelist_.GetSupportedInputMethods().Pass(); On 2014/06/02 06:28:52, Yuki wrote: > No ...

6 years, 6 months ago (2014-06-02 09:45:02 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/306053005/140001

6 years, 6 months ago (2014-06-03 15:58:09 UTC) #5

Message was sent while issue was closed.

Change committed as 274589

Expand Messages | Collapse Messages