Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 306053004: Revert 273601 "Change directory if the active list item on navig..." (Closed)

Created:
6 years, 6 months ago by fukino
Modified:
6 years, 6 months ago
Reviewers:
fukino
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 273601 "Change directory if the active list item on navig..." This broke browser_test on Linux ChromiumOS Tests (dbg). I need to ivestigate it. > Change directory if the active list item on navigation list is changed. > > We want to change current directory if the active item on navigation list is changed. > But we don't want to change current directory when listed items are spliced or permuted. > In both cases, 'change' event is dispatched from selection model and we can't distinguish these cases from event itself. > currentActiveItem_ is introduced to detect change of actual active item. > > BUG=375663 > TEST=go through steps in Issue 375663 and 361047 > > Review URL: https://codereview.chromium.org/303503004 TBR=yoshiki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273724

Patch Set 1 #

Messages

Total messages: 2 (0 generated)
fukino
6 years, 6 months ago (2014-05-30 05:28:57 UTC) #1
fukino
6 years, 6 months ago (2014-05-30 05:29:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r273724.

Powered by Google App Engine
This is Rietveld 408576698