Issue 306053002: Merge 271730 "Workaround bad bitmaps in clibpoard code"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 306053002: Merge 271730 "Workaround bad bitmaps in clibpoard code" (Closed)

Created:
6 years, 6 months ago by piman

Modified:
6 years, 6 months ago

Reviewers:
piman

CC:
chromium-reviews, darin-cc_chromium.org, jam, dcheng

Base URL:
svn://svn.chromium.org/chrome/branches/1916/src/

Visibility:
Public.

Merge 271730 "Workaround bad bitmaps in clibpoard code" > Workaround bad bitmaps in clibpoard code > > - Some bitmaps end up with a NULL getPixels(). Don't try to copy ot of that. > - Only try to copy 32-bit bitmaps > - Protect against overflow in size computation > > BUG=369621 > > Review URL: https://codereview.chromium.org/289573002 TBR=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273614

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
	M	content/renderer/renderer_clipboard_client.cc	View		2 chunks	+8 lines, -1 line	0 comments	Download
	M	content/renderer/webclipboard_impl.cc	View		1 chunk	+8 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

piman

6 years, 6 months ago (2014-05-29 22:03:35 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r273614 (tree was closed).