uber: use the URL to resolve the subpage in popstate.

uber: use the URL to resolve the subpage in popstate.

Otherwise if the initial load does not induce a replaceState, there is not
pageId in the history state to route to. Instead, always route from the URL.
This allows us to just pass-through the page state.

BUG=348948
TEST=See bug

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273934

[davidben, 2014-05-29 20:08:54]

The settings page itself could probably do with the equivalent change too. Would
remove the main cause of the "press back twice in a row" race.

[Dan Beam, 2014-05-29 20:42:10]

https://codereview.chromium.org/306043002/diff/1/chrome/browser/resources/ube...
File chrome/browser/resources/uber/uber.js (right):

https://codereview.chromium.org/306043002/diff/1/chrome/browser/resources/ube...
chrome/browser/resources/uber/uber.js:103: function onPopHistoryState(e) {
what happens in the case of !e.state?  should we probably still have an

  if (!e.state)
    return;

here?

[Dan Beam, 2014-05-29 20:45:52]

lgtm

https://codereview.chromium.org/306043002/diff/1/chrome/browser/resources/ube...
File chrome/browser/resources/uber/uber.js (right):

https://codereview.chromium.org/306043002/diff/1/chrome/browser/resources/ube...
chrome/browser/resources/uber/uber.js:103: function onPopHistoryState(e) {
On 2014/05/29 20:42:10, Dan Beam wrote:
> what happens in the case of !e.state?  should we probably still have an
> 
>   if (!e.state)
>     return;
> 
> here?

nevermind, I see what's happening here (and in uber_utils.js), if this is
undefined it's just ignored (essentially) but the popstate still gets forwarded
to replaceState in the outer frame.

[davidben, 2014-05-29 21:11:30]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-05-29 21:13:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/davidben@chromium.org/306043002/1

[commit-bot: I haz the power, 2014-05-29 23:13:47]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)

[commit-bot: I haz the power, 2014-05-29 23:52:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-29 23:52:06]

Try jobs failed on following builders:
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)

[davidben, 2014-05-30 00:28:11]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-05-30 00:31:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/davidben@chromium.org/306043002/1

[commit-bot: I haz the power, 2014-05-30 03:41:26]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-30 04:05:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-30 04:05:41]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[davidben, 2014-05-30 16:04:47]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-05-30 16:07:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/davidben@chromium.org/306043002/1

[commit-bot: I haz the power, 2014-05-30 16:41:00]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-30 18:26:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-30 18:26:10]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[davidben, 2014-05-30 18:40:39]

On 2014/05/30 18:26:10, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   android_dbg_triggered_tests on tryserver.chromium
>
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

Aargh. The CQ seems to keep getting stuck on the same failure without retrying
the run. That bot seems to have fallen over.

[davidben, 2014-05-30 18:43:59]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-05-30 18:45:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/davidben@chromium.org/306043002/1

[commit-bot: I haz the power, 2014-05-30 23:34:51]

Change committed as 273934