Now catches the error message from RTCPeerConnection and createAnswer/Offer

chrome/test/data/webrtc/peerconnection.js

 /**
  * Copyright 2014 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /**
  * We need a STUN server for some API calls.
  * @private
  */
@@ skipping 41 matching lines @@
  * @param {!Object} constraints Any createOffer constraints.
  */
 function createLocalOffer(constraints) {
   peerConnection_().createOffer(
       function(localOffer) {
         success_('createOffer');
         setLocalDescription(peerConnection, localOffer);
 
         returnToTest('ok-' + JSON.stringify(localOffer));
       },
       function() { failure_('createOffer'); },

[kjellander_chromium, 2014/06/09 19:42:56]

Please fix this one too.
According to the spec, it has the same kind of callback:
http://dev.w3.org/2011/webrtc/editor/webrtc.html#widl-RTCPeerConnection-creat...

[jansson, 2014/06/10 05:50:27]

Done.

       constraints);
 }
 
 /**
  * Asks this page to accept an offer and generate an answer.
  *
  * Returns a string on the format ok-(JSON encoded session description).
  *
  * @param {!string} sessionDescJson A JSON-encoded session description of type
  *     'offer'.
  * @param {!Object} constraints Any createAnswer constraints.
  */
 function receiveOfferFromPeer(sessionDescJson, constraints) {
   offer = parseJson_(sessionDescJson);
   if (!offer.type)
     failTest('Got invalid session description from peer: ' + sessionDescJson);
   if (offer.type != 'offer')
     failTest('Expected to receive offer from peer, got ' + offer.type);
 
   var sessionDescription = new RTCSessionDescription(offer);
   peerConnection_().setRemoteDescription(
       sessionDescription,
       function() { success_('setRemoteDescription'); },
-      function() { failure_('setRemoteDescription'); });
+      function(error) { failure_('setRemoteDescription', error); });
 
   peerConnection_().createAnswer(
       function(answer) {
         success_('createAnswer');
         setLocalDescription(peerConnection, answer);
         returnToTest('ok-' + JSON.stringify(answer));
       },
-      function() { failure_('createAnswer'); },
+      function(error) { failure_('createAnswer', error); },
       constraints);
 }
 
 /**
  * Asks this page to accept an answer generated by the peer in response to a
  * previous offer by this page
  *
  * Returns a string ok-accepted-answer on success.
  *
  * @param {!string} sessionDescJson A JSON-encoded session description of type
  *     'answer'.
  */
 function receiveAnswerFromPeer(sessionDescJson) {
   answer = parseJson_(sessionDescJson);
   if (!answer.type)
     failTest('Got invalid session description from peer: ' + sessionDescJson);
   if (answer.type != 'answer')
     failTest('Expected to receive answer from peer, got ' + answer.type);
 
   var sessionDescription = new RTCSessionDescription(answer);
   peerConnection_().setRemoteDescription(
       sessionDescription,
       function() {
         success_('setRemoteDescription');
         returnToTest('ok-accepted-answer');
       },
-      function() { failure_('setRemoteDescription'); });
+      function(error) { failure_('setRemoteDescription', error); });
 }
 
 /**
  * Adds the local stream to the peer connection. You will have to re-negotiate
  * the call for this to take effect in the call.
  */
 function addLocalStream() {
   addLocalStreamToPeerConnection(peerConnection_());
   returnToTest('ok-added');
 }
@@ skipping 78 matching lines @@
   var iceCandidates = parseJson_(iceCandidatesJson);
   if (!iceCandidates.length)
     throw failTest('Received invalid ICE candidate list from peer: ' +
       iceCandidatesJson);
 
   iceCandidates.forEach(function(iceCandidate) {
     if (!iceCandidate.candidate)
       failTest('Received invalid ICE candidate from peer: ' +
         iceCandidatesJson);
 
     peerConnection_().addIceCandidate(new RTCIceCandidate(iceCandidate));

[kjellander_chromium, 2014/06/09 19:42:56]

This also takes success and failure callback functions. Can you add them too?
http://dev.w3.org/2011/webrtc/editor/webrtc.html#widl-RTCPeerConnection-addIc...

[jansson, 2014/06/10 05:50:27]

Done.

[kjellander_chromium, 2014/06/10 08:55:33]

Have you verified the success callback is actually implemented and is called by
Chrome when running this code?

   });
 
   returnToTest('ok-received-candidates');
 }
 
 /**
  * Returns
  */
 function hasSeenCryptoInSdp() {
   returnToTest(gHasSeenCryptoInSdp);
@@ skipping 22 matching lines @@
   return gPeerConnection;
 }
 
 /** @private */
 function success_(method) {
   debug(method + '(): success.');
 }
 
 /** @private */
 function failure_(method, error) {
-  throw failTest(method + '() failed: ' + error);
+  throw failTest(method + '() failed: ' + JSON.stringify(error);
 }
 
 /** @private */
 function iceCallback_(event) {
   if (event.candidate)
     gIceCandidates.push(event.candidate);
 }
 
 /** @private */
 function setLocalDescription(peerConnection, sessionDescription) {
   if (sessionDescription.sdp.search('a=crypto') != -1 ||
       sessionDescription.sdp.search('a=fingerprint') != -1)
     gHasSeenCryptoInSdp = 'crypto-seen';
 
   peerConnection.setLocalDescription(
     sessionDescription,
     function() { success_('setLocalDescription'); },
-    function() { failure_('setLocalDescription'); });
+    function(error) { failure_('setLocalDescription', error); });
 }
 
 /** @private */
 function addStreamCallback_(event) {
   debug('Receiving remote stream...');
   var videoTag = document.getElementById('remote-view');
   attachMediaStream(videoTag, event.stream);
 }
 
 /** @private */
 function removeStreamCallback_(event) {
   debug('Call ended.');
   document.getElementById('remote-view').src = '';
 }
 
 /**
  * Parses JSON-encoded session descriptions and ICE candidates.
  * @private
  */
 function parseJson_(json) {
   // Escape since the \r\n in the SDP tend to get unescaped.
   jsonWithEscapedLineBreaks = json.replace(/\r\n/g, '\\r\\n');
   try {
     return JSON.parse(jsonWithEscapedLineBreaks);
   } catch (exception) {
     failTest('Failed to parse JSON: ' + jsonWithEscapedLineBreaks + ', got ' +
              exception);
   }
 }