Now catches the error message from RTCPeerConnection and createAnswer/Offer

chrome/test/data/webrtc/manual/peerconnection_manual.js

 /**
  * Copyright 2014 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
  /**
  * See http://dev.w3.org/2011/webrtc/editor/getusermedia.html for more
  * information on getUserMedia. See
  * http://dev.w3.org/2011/webrtc/editor/webrtc.html for more information on
@@ skipping 414 matching lines @@
   global.dtmfSender.insertDTMF(tones, duration, interToneGap);
 }
 
 function handleMessage(peerConnection, message) {
   var parsed_msg = JSON.parse(message);
   if (parsed_msg.type) {
     var session_description = new RTCSessionDescription(parsed_msg);
     peerConnection.setRemoteDescription(
         session_description,
         function() { success_('setRemoteDescription'); },
-        function() { failure_('setRemoteDescription'); });
+        function(error) { failure_('setRemoteDescription', error); });
     if (session_description.type == 'offer') {
       print_('createAnswer with constraints: ' +
             JSON.stringify(global.createAnswerConstraints, null, ' '));
       peerConnection.createAnswer(
         setLocalAndSendMessage_,
-        function() { failure_('createAnswer'); },
+        function(error) { failure_('createAnswer', error); },
         global.createAnswerConstraints);
     }
     return;
   } else if (parsed_msg.candidate) {
     var candidate = new RTCIceCandidate(parsed_msg);
     peerConnection.addIceCandidate(candidate);

[kjellander_chromium, 2014/06/09 19:42:56]

This also takes success and failure callbacks. Can you fix that too in this CL?
http://dev.w3.org/2011/webrtc/editor/webrtc.html#widl-RTCPeerConnection-addIc...

[jansson, 2014/06/10 05:50:27]

Done.

     return;
   }
   error_('unknown message received');
 }
 
 function createPeerConnection(stun_server, useRtpDataChannels) {
   servers = {iceServers: [{url: 'stun:' + stun_server}]};
   try {
     var constraints = { optional: [{ RtpDataChannels: useRtpDataChannels }]};
     peerConnection = new RTCPeerConnection(servers, constraints);
   } catch (exception) {
     error_('Failed to create peer connection: ' + exception);
   }
   peerConnection.onaddstream = addStreamCallback_;
   peerConnection.onremovestream = removeStreamCallback_;
   peerConnection.onicecandidate = iceCallback_;
   peerConnection.ondatachannel = onCreateDataChannelCallback_;
   return peerConnection;
 }
 
 function setupCall(peerConnection) {
   print_('createOffer with constraints: ' +
         JSON.stringify(global.createOfferConstraints, null, ' '));
   peerConnection.createOffer(
       setLocalAndSendMessage_,
-      function() { failure_('createOffer'); },
+      function(error) { failure_('createOffer', error); },
       global.createOfferConstraints);
 }
 
 function answerCall(peerConnection, message) {
   handleMessage(peerConnection, message);
 }
 
 function createDataChannel(peerConnection, label) {
   if (global.dataChannel != null && global.dataChannel.readyState != 'closed')
     error_('Creating DataChannel, but we already have one.');
@@ skipping 401 matching lines @@
   print_(gRequestWebcamAndMicrophoneResult);
 }
 
 /** @private */
 function success_(method) {
   print_(method + '(): success.');
 }
 
 /** @private */
 function failure_(method, error) {
-  error_(method + '() failed: ' + error);
+  error_(method + '() failed: ' + JSON.stringify(error));
 }
 
 /** @private */
 function iceCallback_(event) {
   if (event.candidate)
     sendToPeer(global.remotePeerId, JSON.stringify(event.candidate));
 }
 
 /** @private */
 function setLocalAndSendMessage_(session_description) {
   session_description.sdp =
     global.transformOutgoingSdp(session_description.sdp);
   global.peerConnection.setLocalDescription(
     session_description,
     function() { success_('setLocalDescription'); },
-    function() { failure_('setLocalDescription'); });
+    function(error) { failure_('setLocalDescription', error); });
   print_('Sending SDP message:\n' + session_description.sdp);
   sendToPeer(global.remotePeerId, JSON.stringify(session_description));
 }
 
 /** @private */
 function addStreamCallback_(event) {
   print_('Receiving remote stream...');
   var videoTag = document.getElementById('remote-view');
   attachMediaStream(videoTag, event.stream);
 
@@ skipping 437 matching lines @@
 
 /** @private */
 function readResponseHeader_(request, key) {
   var value = request.getResponseHeader(key);
   if (value == null || value.length == 0) {
     error_('Received empty value ' + value +
            ' for response header key ' + key + '.');
   }
   return parseInt(value);
 }