Now catches the error message from RTCPeerConnection and createAnswer/Offer

While trying to figure out why Firefox does not work with the peerconnection.html page I discovered we never caught the actual error message for RTCPeerConnection and createAnswer/Offer in the error callbacks.


TEST=P2P calls between tabs using Firefox and Chrome.
BUG=378199
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276576

[kjellander_chromium, 2014-06-03 08:05:56]

Can you fix the similar errors in peerconnection.js too? Then automated tests
will produce better errors when/if that starts failing.

[jansson, 2014-06-09 13:30:46]

Done, started some trybots just in case, not sure which ones that actually uses
peerconnection.js. Please advise or just add them.

[kjellander_chromium, 2014-06-09 19:42:56]

https://codereview.chromium.org/306033004/diff/60001/chrome/test/data/webrtc/...
File chrome/test/data/webrtc/manual/peerconnection_manual.js (right):

https://codereview.chromium.org/306033004/diff/60001/chrome/test/data/webrtc/...
chrome/test/data/webrtc/manual/peerconnection_manual.js:447:
peerConnection.addIceCandidate(candidate);
This also takes success and failure callbacks. Can you fix that too in this CL?
http://dev.w3.org/2011/webrtc/editor/webrtc.html#widl-RTCPeerConnection-addIc...

https://codereview.chromium.org/306033004/diff/60001/chrome/test/data/webrtc/...
File chrome/test/data/webrtc/peerconnection.js (right):

https://codereview.chromium.org/306033004/diff/60001/chrome/test/data/webrtc/...
chrome/test/data/webrtc/peerconnection.js:62: function() {
failure_('createOffer'); },
Please fix this one too.
According to the spec, it has the same kind of callback:
http://dev.w3.org/2011/webrtc/editor/webrtc.html#widl-RTCPeerConnection-creat...

https://codereview.chromium.org/306033004/diff/60001/chrome/test/data/webrtc/...
chrome/test/data/webrtc/peerconnection.js:220:
peerConnection_().addIceCandidate(new RTCIceCandidate(iceCandidate));
This also takes success and failure callback functions. Can you add them too?
http://dev.w3.org/2011/webrtc/editor/webrtc.html#widl-RTCPeerConnection-addIc...

[jansson, 2014-06-10 05:50:27]

Now we have to wait for the trybot result ;)

https://codereview.chromium.org/306033004/diff/60001/chrome/test/data/webrtc/...
File chrome/test/data/webrtc/manual/peerconnection_manual.js (right):

https://codereview.chromium.org/306033004/diff/60001/chrome/test/data/webrtc/...
chrome/test/data/webrtc/manual/peerconnection_manual.js:447:
peerConnection.addIceCandidate(candidate);
On 2014/06/09 19:42:56, kjellander wrote:
> This also takes success and failure callbacks. Can you fix that too in this
CL?
>
http://dev.w3.org/2011/webrtc/editor/webrtc.html#widl-RTCPeerConnection-addIc...

Done.

https://codereview.chromium.org/306033004/diff/60001/chrome/test/data/webrtc/...
File chrome/test/data/webrtc/peerconnection.js (right):

https://codereview.chromium.org/306033004/diff/60001/chrome/test/data/webrtc/...
chrome/test/data/webrtc/peerconnection.js:62: function() {
failure_('createOffer'); },
On 2014/06/09 19:42:56, kjellander wrote:
> Please fix this one too.
> According to the spec, it has the same kind of callback:
>
http://dev.w3.org/2011/webrtc/editor/webrtc.html#widl-RTCPeerConnection-creat...

Done.

https://codereview.chromium.org/306033004/diff/60001/chrome/test/data/webrtc/...
chrome/test/data/webrtc/peerconnection.js:220:
peerConnection_().addIceCandidate(new RTCIceCandidate(iceCandidate));
On 2014/06/09 19:42:56, kjellander wrote:
> This also takes success and failure callback functions. Can you add them too?
>
http://dev.w3.org/2011/webrtc/editor/webrtc.html#widl-RTCPeerConnection-addIc...

Done.

[kjellander_chromium, 2014-06-10 08:55:33]

https://codereview.chromium.org/306033004/diff/60001/chrome/test/data/webrtc/...
File chrome/test/data/webrtc/peerconnection.js (right):

https://codereview.chromium.org/306033004/diff/60001/chrome/test/data/webrtc/...
chrome/test/data/webrtc/peerconnection.js:220:
peerConnection_().addIceCandidate(new RTCIceCandidate(iceCandidate));
On 2014/06/10 05:50:27, jansson wrote:
> On 2014/06/09 19:42:56, kjellander wrote:
> > This also takes success and failure callback functions. Can you add them
too?
> >
>
http://dev.w3.org/2011/webrtc/editor/webrtc.html#widl-RTCPeerConnection-addIc...
> 
> Done.

Have you verified the success callback is actually implemented and is called by
Chrome when running this code?

https://codereview.chromium.org/306033004/diff/110001/chrome/test/data/webrtc...
File chrome/test/data/webrtc/manual/peerconnection_manual.js (right):

https://codereview.chromium.org/306033004/diff/110001/chrome/test/data/webrtc...
chrome/test/data/webrtc/manual/peerconnection_manual.js:448: function() {
success_('addIceCandidate success'); },
No need to put the ' success' part in here. For the other functions we've only
passed the function name. Same below for the failure_ call.

[jansson, 2014-06-10 10:08:37]

On 2014/06/10 08:55:33, kjellander wrote:
>
https://codereview.chromium.org/306033004/diff/60001/chrome/test/data/webrtc/...
> File chrome/test/data/webrtc/peerconnection.js (right):
> 
>
https://codereview.chromium.org/306033004/diff/60001/chrome/test/data/webrtc/...
> chrome/test/data/webrtc/peerconnection.js:220:
> peerConnection_().addIceCandidate(new RTCIceCandidate(iceCandidate));
> On 2014/06/10 05:50:27, jansson wrote:
> > On 2014/06/09 19:42:56, kjellander wrote:
> > > This also takes success and failure callback functions. Can you add them
> too?
> > >
> >
>
http://dev.w3.org/2011/webrtc/editor/webrtc.html#widl-RTCPeerConnection-addIc...
> > 
> > Done.
> 
> Have you verified the success callback is actually implemented and is called
by
> Chrome when running this code?
Yes success works, not sure how to verify failed though. Will have a deeper
look. Still waiting for try bots....
> 
>
https://codereview.chromium.org/306033004/diff/110001/chrome/test/data/webrtc...
> File chrome/test/data/webrtc/manual/peerconnection_manual.js (right):
> 
>
https://codereview.chromium.org/306033004/diff/110001/chrome/test/data/webrtc...
> chrome/test/data/webrtc/manual/peerconnection_manual.js:448: function() {
> success_('addIceCandidate success'); },
> No need to put the ' success' part in here. For the other functions we've only
> passed the function name. Same below for the failure_ call.

[jansson, 2014-06-10 10:08:55]

https://codereview.chromium.org/306033004/diff/110001/chrome/test/data/webrtc...
File chrome/test/data/webrtc/manual/peerconnection_manual.js (right):

https://codereview.chromium.org/306033004/diff/110001/chrome/test/data/webrtc...
chrome/test/data/webrtc/manual/peerconnection_manual.js:448: function() {
success_('addIceCandidate success'); },
On 2014/06/10 08:55:33, kjellander wrote:
> No need to put the ' success' part in here. For the other functions we've only
> passed the function name. Same below for the failure_ call.

Done.

[kjellander_chromium, 2014-06-10 11:12:04]

lgtm

[jansson, 2014-06-12 06:00:28]

The CQ bit was checked by jansson@chromium.org

[commit-bot: I haz the power, 2014-06-12 06:05:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jansson@chromium.org/306033004/220001

[commit-bot: I haz the power, 2014-06-12 08:03:28]

Change committed as 276576