Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 306033002: Update post state on navigation within page. (Closed)

Created:
6 years, 6 months ago by Nate Chapin
Modified:
6 years, 6 months ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Visibility:
Public.

Description

Update post state on navigation within page. pushState/replaceState should always report as a GET, even if they happen in a document that was the result of a POST. Currently, POST->replaceState->reload sends a GET (as the spec requires), but we incorrectly show a form resubmission warning. BUG=239907 TEST=NavigationControllerTest.PostThenReplaceStateThenReload Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274069

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix test in debug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1 line) Patch
M content/browser/frame_host/navigation_controller_impl.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 1 2 2 chunks +49 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Nate Chapin
6 years, 6 months ago (2014-05-29 19:21:41 UTC) #1
Nate Chapin
On 2014/05/29 19:21:41, Nate Chapin wrote: FYI, the new test is failing on the trybots ...
6 years, 6 months ago (2014-05-29 22:05:26 UTC) #2
nasko
What is the blink change you mentioned? The chromium side LGTM.
6 years, 6 months ago (2014-05-29 23:11:25 UTC) #3
Nate Chapin
On 2014/05/29 23:11:25, nasko wrote: > What is the blink change you mentioned? > > ...
6 years, 6 months ago (2014-05-29 23:12:01 UTC) #4
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 6 months ago (2014-05-30 16:56:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/306033002/20001
6 years, 6 months ago (2014-05-30 16:59:53 UTC) #6
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 6 months ago (2014-05-30 22:33:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/306033002/40001
6 years, 6 months ago (2014-05-30 22:39:11 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-05-31 03:40:18 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 22:25:16 UTC) #10
Message was sent while issue was closed.
Change committed as 274069

Powered by Google App Engine
This is Rietveld 408576698