chrome/common/child_process_host.cc - Issue 306032: Simplify threading in browser thread by making only ChromeThread deal with di...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/child_process_host.cc

Issue 306032: Simplify threading in browser thread by making only ChromeThread deal with di... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: a few more simplifications Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/child_process_host.cc

===================================================================

--- chrome/common/child_process_host.cc (revision 30037)

+++ chrome/common/child_process_host.cc (working copy)

@@ -242,8 +242,7 @@

ChildProcessHost::Iterator::Iterator()

: all_(true), type_(UNKNOWN_PROCESS) {

- DCHECK(MessageLoop::current() ==

- ChromeThread::GetMessageLoop(ChromeThread::IO)) <<

+ DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO)) <<

"ChildProcessInfo::Iterator must be used on the IO thread.";

iterator_ = Singleton<ChildProcessList>::get()->begin();

}

@@ -251,9 +250,8 @@

ChildProcessHost::Iterator::Iterator(ProcessType type)

: all_(false), type_(type) {

// IO loop can be NULL in unit tests.

- DCHECK(!ChromeThread::GetMessageLoop(ChromeThread::IO) ||

- MessageLoop::current() ==

- ChromeThread::GetMessageLoop(ChromeThread::IO)) <<

+ DCHECK(!MessageLoop::current() ||

+ ChromeThread::CurrentlyOn(ChromeThread::IO)) <<

"ChildProcessInfo::Iterator must be used on the IO thread.";

iterator_ = Singleton<ChildProcessList>::get()->begin();

if (!Done() && (*iterator_)->type() != type_)

« chrome/browser/in_process_webkit/webkit_thread.cc ('K') | « chrome/chrome.gyp ('k') | chrome/common/chrome_plugin_unittest.cc » ('j') | no next file with comments »