chrome/browser/plugin_process_host.cc - Issue 306032: Simplify threading in browser thread by making only ChromeThread deal with di...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/plugin_process_host.cc

Issue 306032: Simplify threading in browser thread by making only ChromeThread deal with di... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: a few more simplifications Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/in_process_webkit/webkit_thread.cc ('K') | « chrome/browser/notifications/notification_object_proxy.cc ('k') | chrome/browser/plugin_process_host_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/plugin_process_host.cc

===================================================================

--- chrome/browser/plugin_process_host.cc (revision 30037)

+++ chrome/browser/plugin_process_host.cc (working copy)

@@ -338,11 +338,11 @@

for (window_index = plugin_fullscreen_windows_set_.begin();

window_index != plugin_fullscreen_windows_set_.end();

window_index++) {

- if (MessageLoop::current() ==

- ChromeThread::GetMessageLoop(ChromeThread::UI)) {

+ if (ChromeThread::CurrentlyOn(ChromeThread::UI)) {

mac_util::ReleaseFullScreen();

} else {

- ChromeThread::GetMessageLoop(ChromeThread::UI)->PostTask(FROM_HERE,

+ ChromeThread::PostTask(

+ ChromeThread::UI, FROM_HERE,

NewRunnableFunction(mac_util::ReleaseFullScreen));

}

@@ -670,8 +670,7 @@

void PluginProcessHost::OnPluginMessage(

const std::vector<uint8>& data) {

- DCHECK(MessageLoop::current() ==

- ChromeThread::GetMessageLoop(ChromeThread::IO));

+ DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO));

ChromePluginLib *chrome_plugin = ChromePluginLib::Find(info_.path);

if (chrome_plugin) {